Conversation
Person attributes, create person
- Merged Create and Remove tests into one using Guard Assertion convention. - Add Etag property to Person model. - Tests green
DanielLarsenNZ
requested changes
Jul 26, 2021
Comment on lines
+71
to
+76
| private T ItemWithETag(ItemResponse<T> response) | ||
| { | ||
| T item = response.Resource; | ||
| item.ETag = response.ETag; | ||
| return item; | ||
| } |
Owner
There was a problem hiding this comment.
Actually, I think we can just decorate the ETag property with a JsonProperty. See the Model class to see what I mean.
| [JsonProperty("id")] | ||
| public string Id { get; set; } | ||
|
|
||
| public string ETag { get; set; } |
Owner
There was a problem hiding this comment.
Add
[JsonProperty("_etag")]and this should serialise / de-serialise from Cosmos without the need for an ItemWithETag helper
| @@ -1,4 +1,5 @@ | |||
| using System; | |||
Owner
There was a problem hiding this comment.
Person.cs should be moved to the Test project and deleted from this project as per #2
| @@ -0,0 +1,36 @@ | |||
| using System; | |||
Owner
There was a problem hiding this comment.
MockPeopleData can be deleted
ncostar
force-pushed
the
remove-person-test
branch
from
7b9d235 to
abedc2d
Compare
Collaborator
Author
|
Should be resolved now @DanielLarsenNZ |
ncostar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.