feat: LHCb modules migration#97
Conversation
|
There is an issue with the FailoverRequest. |
c3f5c70 to
93cb40c
Compare
|
This PR will now tackle the migration of every single module (starting from the ones used in MCSim) by importing LHCb specific functions instead of rewritting them from the ground up |
First approach, needs review
Improve UploadLogFile tests
ca676da to
98ccc37
Compare
6511abe to
1da58a2
Compare
chore: Create proper wf_commons file update
c3b1414 to
947bc8b
Compare
2e7ae71 to
ed1c6f0
Compare
| value = returnValueOrRaise(workflow_commons.file_report.generateForwardDISET()) | ||
| if not value: | ||
| logger.info("On second attempt, files correctly reported to TransformationDB") | ||
| elif workflow_commons.step_status == StepStatus.Done: |
There was a problem hiding this comment.
Also based on my previous comment in the WorkflowAccounting: it would be interesting to see whether there is a way to get the status of the cwl execution vs a step execution.
Because if this is possible, then may be there is a way to reproduce exactly what we have in the workflow modules with the conditions like if workflowStatus and jobStatus...
| f"Values for StepAccounting are wrong. Here are the given data: {data_dict}" | ||
| ) from e | ||
|
|
||
| workflow_commons.dsc.addRegister(job_step) |
There was a problem hiding this comment.
Why wouldn't it?
When the command execution ends, the registers are extracted from the client and stored for later use.
| Failed = "Failed" | ||
|
|
||
|
|
||
| class Step(BaseModel): |
There was a problem hiding this comment.
There might be a way of having one step per CWL workflow step.
Check the workflow examples we have here (this is not MCSim but it's very similar): https://gitlab.cern.ch/lhcb-dpa/analysis-productions/lbapcommon/-/blob/master/tests/example_workflows/complex_workflow_with_filtering/AnaProd_example_workflows_job_tuple%2Csplit%2Cfilter_B0.cwl?ref_type=heads
There was a problem hiding this comment.
Okay, I will look into this
ddbbd58 to
cbe026f
Compare
cbe026f to
7b3d120
Compare
See #87
First approach, needs review.
I tried to use the current Mock classes (MockDataManager), but I don't think this is the correct way. However, it should not vary much.
I open it as a draft because I still need to create 2 more tests and change the interactions with DIRAC.