ci: add flaky-test management (#489)#17
Open
MichaelTaylor3d wants to merge 4 commits into
Open
Conversation
Switch the CI test job to cargo-nextest (--retries 2) so intermittent test failures surface as FLAKY in the run summary instead of being silently retried away; doctests (unsupported by nextest) run as a separate step to preserve coverage. Applied to both the workspace test job and the dig-client-wasm parity-test job. Audited the tag/deploy/publish workflows (release.yml, publish-binary.yml, publish-npm.yml): none re-run the full PR-gated test suite at deploy time. publish-binary.yml's targeted dighost_serve contract gate stays — it verifies the actual release-target (static-musl) binary's proof output against the deployed verifier, not a redundant full-suite re-run. Cargo.toml workspace version bumped 0.13.0 -> 0.13.1 (patch, CI-only change, no public API/behaviour change); Cargo.lock version entries for the workspace-version-tracking crates updated to match. Co-Authored-By: Claude <noreply@anthropic.com>
cargo nextest run does not instrument coverage; a bare nextest step alongside cargo-llvm-cov collects zero lines and silently drops the >=80% gate. Switch both test steps to the combined `cargo llvm-cov nextest --fail-under-lines 80` form so llvm-cov drives nextest directly and the coverage gate keeps enforcing. Co-Authored-By: Claude <noreply@anthropic.com>
dig-client-wasm's own-file coverage isn't meaningful (its wasm-bindgen glue is exercised by the "Verify assembled package" e2e step, not the native parity tests); adding --fail-under-lines there just introduced a new, unrelated failure. Revert that job to plain flaky-aware nextest and keep the llvm-cov+nextest combined coverage gate on the workspace build & test job, which is what CLAUDE.md's coverage-gate rule targets. Co-Authored-By: Claude <noreply@anthropic.com>
…489) cargo llvm-cov nextest slowed the instrumented digstore binary that CLI integration tests spawn as a child process (e.g. cli_dev's dev-server startup poll), consistently blowing existing CI-tuned timeouts and failing on both ubuntu-latest and windows-latest. main has no coverage gate today, so this flaky-test-management PR must not introduce one (a stricter gate than main is out of scope here). Keep nextest's flaky-run detection/retries; drop llvm-cov instrumentation and the 80%-lines gate entirely — a future PR can add coverage measurement as its own reviewable change. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
digstore-cli+ libs), no JS/vitest/Playwright/RTL surface in this repo.ci.yml) to cargo-nextest with--retries 2for both the main workspace test job and thedig-client-wasmparity-test job — nextest natively flags retried-then-passed tests asFLAKYin the run summary instead of silently hiding them. Doctests (unsupported by nextest) now run as an explicit separate step so doctest coverage isn't dropped.release.yml(tag-triggered) andpublish-npm.yml(release-triggered) build/package/publish only — no test re-run to remove.publish-binary.yml(push-to-main triggered) runs one targeted contract gate (dighost_serve) that verifies the actual release-target (static-musl) binary's proof output against the deployed verifier — kept, since it's not a redundant re-run of the PR-gated full suite but a build-specific correctness check on the artifact about to publish.Cargo.tomlworkspace version0.13.0->0.13.1(patch — CI-only change, no public API/behaviour change);Cargo.lockversion entries for the workspace-version-tracking crates (digstore-chain/-chunker/-cli/-core/-remote) updated to match.Refs #489
Test plan
Co-Authored-By: Claude noreply@anthropic.com