Skip to content

fixes a bug in contract when the two fermionic tensors have no common labels - #1186

Merged
manuschneider merged 2 commits into
masterfrom
fermion_fix
Sep 21, 2026
Merged

manuschneider merged 2 commits into
masterfrom
fermion_fix

Conversation

@manuschneider

Copy link
Copy Markdown
Collaborator

Fixes #1033
Also minor fixes of comments, and removal of an unused variable.

… labels (outer product)

fixes some comments and removes unused variables
@manuschneider manuschneider added bug Something isn't working fermions labels Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.89%. Comparing base (f5b33cf) to head (2a9ecfd).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1186   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files         208      208           
  Lines       22411    22406    -5     
  Branches       72       72           
=======================================
- Hits        15439    15437    -2     
+ Misses       6950     6947    -3     
  Partials       22       22           
Flag Coverage Δ
cpp 68.98% <100.00%> (+<0.01%) ⬆️
python 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
C++ backend 68.98% <100.00%> (+<0.01%) ⬆️
Python bindings ∅ <ø> (∅)
Python package 63.96% <ø> (ø)
Files with missing lines Coverage Δ
include/Symmetry.hpp 7.01% <ø> (ø)
src/BlockFermionicUniTensor.cpp 65.65% <100.00%> (-0.06%) ⬇️
src/Bond.cpp 65.96% <100.00%> (-0.31%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b33cf...2a9ecfd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/BlockFermionicUniTensor.cpp Outdated
Comment thread src/BlockFermionicUniTensor.cpp Outdated
@manuschneider
manuschneider merged commit f6b5874 into master Sep 21, 2026
24 checks passed
@manuschneider
manuschneider deleted the fermion_fix branch September 21, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fermions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fermionic no-common-label contract suspicious code

2 participants