Refactor Nvidia Workaround#1386
Conversation
|
I just realized, that we could use the |
|
@RayJW Yes this dependency looks good. It seems pretty small and is a no-op on non-linux OS'es. Would you like to implement this dependency? |
117f623 to
df1f8e5
Compare
Done :) |
7c7a9ec to
24ff452
Compare
24ff452 to
3127f8e
Compare
|
Hi @RayJW, Could we achieve this without adding a separate linux_gpu_optimization_migrated_v1 setting entry / migration logic? While I know that's the cleanest option for the enduser, I'm not sure if the added maintenance overhead makes sense here. As this is my first larger application, I'd really appreciate your opinion on it. Thanks a lot! Timon |
Honestly, I would keep it. It's just 12 lines of code, runs once, and worst case we can always remove it without any repercussions later on. I hope that makes sense? :) |
|
Thanks for the explaination - that makes sense. Have a nice evening, |
Description
This reworks the workaround for Linux system to only automatically apply to Nvidia systems, and use a softer workaround
__NV_DISABLE_EXPLICIT_SYNC=1, that doesn't disable hardware rendering (thanks to this comment).The original toggle is preserved as a last resort solution, but not enabled by default any more. This should greatly improve the user experience on Linux systems for basically every one.
Type of Change
Changes Made
Testing
Test Configuration:
Checklist
Additional Notes
It would obviously be great if more people could test this. Ideally at least someone previously affected by the crashes to ensure it doesn't re-introduce that.
AI Disclaimer:
Please state the involvement of AI in this PR: