fix(i18n): fill Chinese gaps in metadata and dialogs#1360
Closed
VailElla wants to merge 2 commits into
Closed
Conversation
VailElla
force-pushed
the
codex/zh-cn-completion
branch
from
July 12, 2026 13:10
af62264 to
8d6b25c
Compare
VailElla
marked this pull request as ready for review
July 12, 2026 13:11
VailElla
force-pushed
the
codex/zh-cn-completion
branch
from
July 12, 2026 22:34
8d6b25c to
7dd7b4c
Compare
VailElla
force-pushed
the
codex/zh-cn-completion
branch
from
July 12, 2026 22:43
7dd7b4c to
2a1b75e
Compare
VailElla
force-pushed
the
codex/zh-cn-completion
branch
from
July 12, 2026 23:33
2a1b75e to
8a1f13e
Compare
16 tasks
Contributor
Author
|
This PR is superseded by #1370. The replacement is based on the current upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes several user-visible Simplified and Traditional Chinese localization gaps in metadata, filename controls, import dialogs, and the macOS native file picker.
The change keeps canonical filename tokens unchanged while localizing their presentation labels, routes the supported EXIF field names and enum values through i18next, preserves user-entered/free-form metadata, and declares the supported macOS bundle localizations.
Type of Change
Changes Made
Screenshots/Videos
Import settings
Shows the localized import dialog, filename field, and localized variable labels while retaining the canonical {original_filename} token.
Export filename controls
Shows multi-image export with localized filename-variable buttons and the unchanged editable token syntax.
Metadata panel
Shows the localized metadata sections, EXIF field labels, and supported enum values using synthetic camera data.
Testing
I have tested these changes locally and confirmed that they work as expected without issues
npm run build — passed; only the existing large-chunk warning remains
plutil -lint src-tauri/Info.plist — passed
git diff --check origin/main...HEAD — passed
Manual macOS QA with two synthetic JPEG fixtures:
npm run typecheck, npm run lint, and npm run i18n:check still report existing repository-wide baseline findings; no new diagnostics were isolated to the touched code or newly added locale keys
Test Configuration:
Checklist
Additional Notes
The editable filename template intentionally keeps canonical tokens such as {original_filename}; translating that protocol would break cross-language preset and clipboard portability.
The screenshots are committed under docs/screenshots/pr-1360/ so the evidence is reproducible and does not depend on personal uploads or expiring attachments.
AI Disclaimer