Skip to content

fix(i18n): fill Chinese gaps in metadata and dialogs#1360

Closed
VailElla wants to merge 2 commits into
CyberTimon:mainfrom
VailElla:codex/zh-cn-completion
Closed

fix(i18n): fill Chinese gaps in metadata and dialogs#1360
VailElla wants to merge 2 commits into
CyberTimon:mainfrom
VailElla:codex/zh-cn-completion

Conversation

@VailElla

@VailElla VailElla commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes several user-visible Simplified and Traditional Chinese localization gaps in metadata, filename controls, import dialogs, and the macOS native file picker.

The change keeps canonical filename tokens unchanged while localizing their presentation labels, routes the supported EXIF field names and enum values through i18next, preserves user-entered/free-form metadata, and declares the supported macOS bundle localizations.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Code refactoring
  • Documentation update
  • UI/UX improvement
  • Build/CI or Dependency update

Changes Made

  • Localize supported extended EXIF field names and common enum values in Simplified and Traditional Chinese
  • Restrict EXIF enum translation to the relevant fields so free-form metadata is never translated accidentally
  • Localize unknown numeric TIFF tag labels in every shipped locale
  • Localize filename-variable button labels in export, import, and batch rename
  • Preserve canonical filename syntax such as {original_filename} in editable templates, saved presets, copy/paste, and backend calls
  • Localize built-in tag suggestions and display labels in metadata, context menus, and shortcut settings while preserving canonical saved tag values
  • Localize import file filters, dialog title, and unsupported-format errors in every shipped locale
  • Remove duplicated hardcoded English from the sidecar cleanup description
  • Change the Simplified Chinese photography term for Clone from 克隆 to 仿制 and add missing clone/heal plural forms
  • Declare supported bundle localizations so macOS native Open panels follow the preferred system language

Screenshots/Videos

Import settings

Shows the localized import dialog, filename field, and localized variable labels while retaining the canonical {original_filename} token.

Import settings localization

Export filename controls

Shows multi-image export with localized filename-variable buttons and the unchanged editable token syntax.

Export filename localization

Metadata panel

Shows the localized metadata sections, EXIF field labels, and supported enum values using synthetic camera data.

Metadata localization

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

  • npm run build — passed; only the existing large-chunk warning remains

  • plutil -lint src-tauri/Info.plist — passed

  • git diff --check origin/main...HEAD — passed

  • Manual macOS QA with two synthetic JPEG fixtures:

    • Import settings shows localized filename-variable labels and preserves canonical tokens
    • Export panel shows localized filename-variable labels for a multi-image selection
    • Metadata panel shows localized sections, EXIF labels, built-in tag labels, and supported enum values
    • No personal image, GPS, home-folder path, or private metadata is used in the screenshots
  • npm run typecheck, npm run lint, and npm run i18n:check still report existing repository-wide baseline findings; no new diagnostics were isolated to the touched code or newly added locale keys

Test Configuration:

  • OS: macOS 26.5.2
  • Hardware: Apple M4 Pro (arm64)

Checklist

  • My code follows the project code style
  • I have not added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

Additional Notes

The editable filename template intentionally keeps canonical tokens such as {original_filename}; translating that protocol would break cross-language preset and clipboard portability.

The screenshots are committed under docs/screenshots/pr-1360/ so the evidence is reproducible and does not depend on personal uploads or expiring attachments.

AI Disclaimer

  • This PR is entirely AI-generated
  • This PR is AI-generated but guided by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@VailElla
VailElla force-pushed the codex/zh-cn-completion branch from af62264 to 8d6b25c Compare July 12, 2026 13:10
@VailElla
VailElla marked this pull request as ready for review July 12, 2026 13:11
@VailElla
VailElla requested a review from CyberTimon as a code owner July 12, 2026 13:11
@VailElla
VailElla force-pushed the codex/zh-cn-completion branch from 8d6b25c to 7dd7b4c Compare July 12, 2026 22:34
@VailElla VailElla changed the title fix(i18n): complete Chinese localization for EXIF and macOS dialogs fix(i18n): complete Chinese localization across metadata and dialogs Jul 12, 2026
@VailElla
VailElla force-pushed the codex/zh-cn-completion branch from 7dd7b4c to 2a1b75e Compare July 12, 2026 22:43
@VailElla
VailElla force-pushed the codex/zh-cn-completion branch from 2a1b75e to 8a1f13e Compare July 12, 2026 23:33
@VailElla VailElla changed the title fix(i18n): complete Chinese localization across metadata and dialogs fix(i18n): fill Chinese gaps in metadata and dialogs Jul 12, 2026
@VailElla VailElla mentioned this pull request Jul 13, 2026
16 tasks
@VailElla

Copy link
Copy Markdown
Contributor Author

This PR is superseded by #1370. The replacement is based on the current upstream main, keeps the localization scope isolated, and preserves the current Simplified Chinese terminology. Thank you!

@VailElla VailElla closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant