fix(raw): decode Samsung linear DNGs correctly#4
Open
VailElla wants to merge 5 commits into
Open
Conversation
16 tasks
VailElla
marked this pull request as ready for review
July 15, 2026 02:25
VailElla
force-pushed
the
codex/fix-samsung-linear-dng-decoding
branch
from
July 15, 2026 21:54
528ffb3 to
6ac6ec2
Compare
|
Wouldn't it be better to submit the pull request to dnglab itself? This way, when Timon updates this fork, the changes will be pulled in automatically |
Author
|
Thanks — agreed. I moved the decoder changes to a clean branch based on I’ll keep this PR open temporarily because CyberTimon/RapidRAW#1380 currently pins this fork revision. Once the upstream PR is merged and this fork is synced, I’ll update the RapidRAW dependency and close this PR as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
These decoder changes have been resubmitted upstream as dnglab/dnglab#810. This downstream PR remains open temporarily because CyberTimon/RapidRAW#1380 currently pins commit
ee86c32e3d85ff6057fdc8b3c3eed38923712d91. Once the upstream PR is merged and this fork is synchronized, RapidRAW's dependency will be refreshed and this PR will be closed as superseded.Summary
BlackLevelRepeatDimfor interleaved linear DNG data instead of assuming the black- and white-level arrays have the same lengthRoot cause and impact
This enables the decoder-side fixes needed by:
Both public issue samples now complete full RAW decoding. This PR intentionally does not implement default-rendering metadata such as
BaselineExposureorOpcodeList2gain maps; those belong to later rendering stages. RapidRAW#1380 applies baseline exposure, while GainMap rendering remains a planned follow-up and pixel parity is not claimed here.Validation
cargo +1.96.1 test -p rawler --test linear_blacklevel --test jpeg_restart(18 passed)cargo +1.96.1 check -p rawlercargo +1.96.1 build -p dnglabdnglab analyze --raw-checksumfedb82718ee20b5a309678872527cb7551abe49e5950c6987ac347548c2ac487The issue fixtures are used only for local validation and are not included in this branch.