Skip to content

fix(infra): stop Terraform clobbering app runtime secret on every apply #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arielr-lt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(infra): stop Terraform clobbering app runtime secret on every apply #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions infra/terraform/envs/production/app-deps.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,4 +275,14 @@ resource "aws_secretsmanager_secret" "app" {
resource "aws_secretsmanager_secret_version" "app" {
secret_id = aws_secretsmanager_secret.app.id
secret_string = jsonencode(local.app_secret_values)

# Terraform only *seeds* this secret on first creation. Runtime values
# (notably ENCRYPTION_KEY, plus anything set via the "Update app env vars"
# workflow) are managed out-of-band in Secrets Manager and must survive
# later applies. Without this, every apply rewrites the blob from
# local.app_secret_values — regenerating ENCRYPTION_KEY and orphaning all
# data already encrypted under the previous key.
lifecycle {
ignore_changes = [secret_string]
}
}
10 changes: 10 additions & 0 deletions infra/terraform/envs/sandbox/app-deps.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,14 @@ resource "aws_secretsmanager_secret" "app" {
resource "aws_secretsmanager_secret_version" "app" {
secret_id = aws_secretsmanager_secret.app.id
secret_string = jsonencode(local.app_secret_values)

# Terraform only *seeds* this secret on first creation. Runtime values
# (notably ENCRYPTION_KEY, plus anything set via the "Update app env vars"
# workflow) are managed out-of-band in Secrets Manager and must survive
# later applies. Without this, every apply rewrites the blob from
# local.app_secret_values — regenerating ENCRYPTION_KEY and orphaning all
# data already encrypted under the previous key.
lifecycle {
ignore_changes = [secret_string]
}
}
10 changes: 10 additions & 0 deletions infra/terraform/envs/test/app-deps.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,14 @@ resource "aws_secretsmanager_secret" "app" {
resource "aws_secretsmanager_secret_version" "app" {
secret_id = aws_secretsmanager_secret.app.id
secret_string = jsonencode(local.app_secret_values)

# Terraform only *seeds* this secret on first creation. Runtime values
# (notably ENCRYPTION_KEY, plus anything set via the "Update app env vars"
# workflow) are managed out-of-band in Secrets Manager and must survive
# later applies. Without this, every apply rewrites the blob from
# local.app_secret_values — regenerating ENCRYPTION_KEY and orphaning all
# data already encrypted under the previous key.
lifecycle {
ignore_changes = [secret_string]
}
}
Loading