Skip to content

Fix fluid transfer bugs for amounts over one bucket#10604

Open
Apertyotis wants to merge 1 commit into
Creators-of-Create:mc1.21.1/devfrom
Apertyotis:fix/fill-with-a-bucket
Open

Fix fluid transfer bugs for amounts over one bucket#10604
Apertyotis wants to merge 1 commit into
Creators-of-Create:mc1.21.1/devfrom
Apertyotis:fix/fill-with-a-bucket

Conversation

@Apertyotis

Copy link
Copy Markdown
Contributor

Similar to #9974 , this PR fixes two places that do not correctly handle fluid transfers exceeding 1000 mB in a single operation.

For example, 8 Mechanical Pumps at 256 RPM produce a transfer rate of 1024 mB/t. When inserting into HosePulleyFluidHandler, the simulation incorrectly reports that only 24 mB can be accepted, causing the actual transfer rate to drop to 24 mB/t.

OpenEndFluidHandler has a similar issue. When more than 1000 mB is inserted at once, it incorrectly determines that the fluid to be placed in the world is air and rejects the transfer entirely.

Note: Please use fluids such as Chocolate or Honey for the second test. Water and Lava are not suitable, as they always attempt to fill 1 mB first and then the remaining 999 mB, preventing a single transfer larger than one bucket from occurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant