Fix fluid transfer bugs for amounts over one bucket#10604
Open
Apertyotis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #9974 , this PR fixes two places that do not correctly handle fluid transfers exceeding
1000 mBin a single operation.For example, 8 Mechanical Pumps at 256 RPM produce a transfer rate of 1024 mB/t. When inserting into
HosePulleyFluidHandler, the simulation incorrectly reports that only 24 mB can be accepted, causing the actual transfer rate to drop to 24 mB/t.OpenEndFluidHandlerhas a similar issue. When more than 1000 mB is inserted at once, it incorrectly determines that the fluid to be placed in the world is air and rejects the transfer entirely.