Fix copper doors and wooden door sounds#10565
Open
johnhoffm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10435
While I was adding that logic, I noticed that the wood types all sounded the same. Cherry, bamboo, and nether wood should have slightly different sounds for doors, trapdoors, and fence gates (https://minecraft.wiki/w/Door#Cherry_wood). So I fixed that as well.
Note that I'm using the MOB_INTERACTABLE_DOORS block tag to determine which doors are interactable on contraptions since it contains all of the doors we want, ie the non iron doors. You may want to revert that if you believe that mob interactable does not necessarily imply player interactable.
I don't have an easy way of recording audio so here is a screenshot of the test.