Skip to content

Add EPICS_PVA_TLS_KEYCHAIN_PWD_FILE for file-based keychain password #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
george-mcintyre wants to merge 2 commits into
base: master
Choose a base branch
from
+66 −6

Declare and document EPICS_PVA(S)_TLS_KEYCHAIN_PWD_FILE in PVASettings

cd72fb5
Select commit
Loading
Failed to load commit list.
Open

Add EPICS_PVA_TLS_KEYCHAIN_PWD_FILE for file-based keychain password #3783

Declare and document EPICS_PVA(S)_TLS_KEYCHAIN_PWD_FILE in PVASettings
cd72fb5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 15, 2026 in 2m 50s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 75 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RmaDmAfTdVnF5O6vE&open=AZ2RmaDmAfTdVnF5O6vE&pullRequest=3783

Check warning on line 170 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make EPICS_PVAS_TLS_KEYCHAIN_PWD_FILE a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q6&open=AZ2R3p3UAHiTsgjSl_q6&pullRequest=3783

Check warning on line 216 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make EPICS_PVA_TLS_KEYCHAIN_PWD_FILE a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q7&open=AZ2R3p3UAHiTsgjSl_q7&pullRequest=3783

Check warning on line 170 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "EPICS_PVAS_TLS_KEYCHAIN_PWD_FILE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q-&open=AZ2R3p3UAHiTsgjSl_q-&pullRequest=3783

Check warning on line 216 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static EPICS_PVA_TLS_KEYCHAIN_PWD_FILE" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q9&open=AZ2R3p3UAHiTsgjSl_q9&pullRequest=3783

Check warning on line 216 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "EPICS_PVA_TLS_KEYCHAIN_PWD_FILE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q_&open=AZ2R3p3UAHiTsgjSl_q_&pullRequest=3783

Check warning on line 152 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Lambda should be used to defer string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RmaDmAfTdVnF5O6vF&open=AZ2RmaDmAfTdVnF5O6vF&pullRequest=3783

Check warning on line 170 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static EPICS_PVAS_TLS_KEYCHAIN_PWD_FILE" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2R3p3UAHiTsgjSl_q8&open=AZ2R3p3UAHiTsgjSl_q8&pullRequest=3783
View more details on SonarQubeCloud