Skip to content

feat (display): RTTank-based Progress Bar backend — scale, alarm limits, and stacking support (opt-in via preference) #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilioheredia-source wants to merge 11 commits into
base: master
Choose a base branch
from

fix(rtplot): simplify inset comment + extract drawAlarmLimits() to re…

395fc79
Select commit
Loading
Failed to load commit list.
Open

feat (display): RTTank-based Progress Bar backend — scale, alarm limits, and stacking support (opt-in via preference) #3768

fix(rtplot): simplify inset comment + extract drawAlarmLimits() to re…
395fc79
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 4, 2026 in 1m 5s

Quality Gate passed

Issues
53 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 218 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVh&open=AZ1ZWMYC8MsCUjGKMPVh&pullRequest=3768

Check failure on line 264 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propShowScaleLabels" to prevent any misunderstanding/clash with field "propShowScaleLabels" defined in superclass "org.csstudio.display.builder.model.widgets.ScaledPVWidget". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVr&open=AZ1ZWMYC8MsCUjGKMPVr&pullRequest=3768

Check warning on line 192 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "opposite_scale_visible" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVl&open=AZ1ZWMYC8MsCUjGKMPVl&pullRequest=3768

Check warning on line 330 in app/display/model/src/main/java/org/csstudio/display/builder/model/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make WidgetProperties_ShowScaleLabels a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMb08MsCUjGKMPV2&open=AZ1ZWMb08MsCUjGKMPV2&pullRequest=3768

Check warning on line 189 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPV8&open=AZ1ZWMcB8MsCUjGKMPV8&pullRequest=3768

Check warning on line 216 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVf&open=AZ1ZWMYC8MsCUjGKMPVf&pullRequest=3768

Check warning on line 193 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "perpendicular_tick_labels" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVm&open=AZ1ZWMYC8MsCUjGKMPVm&pullRequest=3768

Check warning on line 253 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare "lo" and all following declarations on a separate line. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPWG&open=AZ1ZWMcB8MsCUjGKMPWG&pullRequest=3768

Check warning on line 195 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "inner_padding_prop" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVo&open=AZ1ZWMYC8MsCUjGKMPVo&pullRequest=3768

Check warning on line 194 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "border_width_prop" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVn&open=AZ1ZWMYC8MsCUjGKMPVn&pullRequest=3768

Check warning on line 92 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "was_transformed" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPWF&open=AZ1ZWMcB8MsCUjGKMPWF&pullRequest=3768

Check warning on line 168 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/TankWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMa-8MsCUjGKMPVw&open=AZ1ZWMa-8MsCUjGKMPVw&pullRequest=3768

Check warning on line 100 in app/rtplot/src/main/java/org/csstudio/javafx/rtplot/RTTank.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "inner_padding" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMeS8MsCUjGKMPWK&open=AZ1ZWMeS8MsCUjGKMPWK&pullRequest=3768

Check warning on line 214 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVd&open=AZ1ZWMYC8MsCUjGKMPVd&pullRequest=3768

Check warning on line 330 in app/display/model/src/main/java/org/csstudio/display/builder/model/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static WidgetProperties_ShowScaleLabels" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMb08MsCUjGKMPV4&open=AZ1ZWMb08MsCUjGKMPV4&pullRequest=3768

Check failure on line 270 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propOppositeScaleVisible" to prevent any misunderstanding/clash with field "propOppositeScaleVisible" defined in superclass "org.csstudio.display.builder.model.widgets.ScaledPVWidget". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVs&open=AZ1ZWMYC8MsCUjGKMPVs&pullRequest=3768

Check warning on line 238 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPV_&open=AZ1ZWMcB8MsCUjGKMPV_&pullRequest=3768

Check failure on line 276 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propPerpendicularTickLabels" to prevent any misunderstanding/clash with field "propPerpendicularTickLabels" defined in superclass "org.csstudio.display.builder.model.widgets.ScaledPVWidget". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVt&open=AZ1ZWMYC8MsCUjGKMPVt&pullRequest=3768

Check warning on line 254 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPWD&open=AZ1ZWMcB8MsCUjGKMPWD&pullRequest=3768

Check warning on line 201 in app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/RTScaledWidgetRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMcB8MsCUjGKMPWB&open=AZ1ZWMcB8MsCUjGKMPWB&pullRequest=3768

Check failure on line 288 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propInnerPadding" to prevent any misunderstanding/clash with field "propInnerPadding". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVv&open=AZ1ZWMYC8MsCUjGKMPVv&pullRequest=3768

Check warning on line 212 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVb&open=AZ1ZWMYC8MsCUjGKMPVb&pullRequest=3768

Check failure on line 227 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/TankWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propShowScaleLabels" to prevent any misunderstanding/clash with field "propShowScaleLabels" defined in superclass "org.csstudio.display.builder.model.widgets.ScaledPVWidget". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMa-8MsCUjGKMPVz&open=AZ1ZWMa-8MsCUjGKMPVz&pullRequest=3768

Check warning on line 215 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/ProgressBarWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the assignment out of this expression. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMYC8MsCUjGKMPVe&open=AZ1ZWMYC8MsCUjGKMPVe&pullRequest=3768

Check failure on line 257 in app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/TankWidget.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "propBorderWidth" to prevent any misunderstanding/clash with field "propBorderWidth" defined in superclass "org.csstudio.display.builder.model.widgets.ScaledPVWidget". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ1ZWMa-8MsCUjGKMPV0&open=AZ1ZWMa-8MsCUjGKMPV0&pullRequest=3768
View more details on SonarQubeCloud