Skip to content

Support add/remove attachments when editing Olog entry #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgweiss wants to merge 5 commits into
base: master
Choose a base branch
from

Fix for: embedded images not shown in preview when editing log entry

04e023c
Select commit
Loading
Failed to load commit list.
Open

Support add/remove attachments when editing Olog entry #3754

Fix for: embedded images not shown in preview when editing log entry
04e023c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 30, 2026 in 1m 36s

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 509 in app/logbook/olog/client-es/src/main/java/org/phoebus/olog/es/api/OlogHttpClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers or lambda should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ0-tbpoGOacgaJbp9zA&open=AZ0-tbpoGOacgaJbp9zA&pullRequest=3754

Check warning on line 209 in app/logbook/olog/client-es/src/main/java/org/phoebus/olog/es/api/OlogHttpClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ0-tbpoGOacgaJbp9y9&open=AZ0-tbpoGOacgaJbp9y9&pullRequest=3754

Check warning on line 309 in app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/AttachmentsViewController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ0-tbvoGOacgaJbp9zB&open=AZ0-tbvoGOacgaJbp9zB&pullRequest=3754

Check warning on line 209 in app/logbook/olog/client-es/src/main/java/org/phoebus/olog/es/api/OlogHttpClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers or lambda should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ0-tbpoGOacgaJbp9y_&open=AZ0-tbpoGOacgaJbp9y_&pullRequest=3754

Check warning on line 509 in app/logbook/olog/client-es/src/main/java/org/phoebus/olog/es/api/OlogHttpClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ0-tbpoGOacgaJbp9y-&open=AZ0-tbpoGOacgaJbp9y-&pullRequest=3754
View more details on SonarQubeCloud