Skip to content

Better error logging on event failure #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakequade-pc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better error logging on event failure #450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffde05e
Better error logging on event failure
jakequade-pc May 6, 2026
d429a77
Update events.js
jakequade-pc May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ EventEmitter.prototype.emit = function emit(type) {
throw er; // Unhandled 'error' event
}
// At least give some kind of context to the user
var err = new Error('Unhandled error.' + (er ? ' (' + er.message + ')' : ''));
var err = new Error('Unhandled error.' + (er && er.message ? ' (' + er.message + ')' : JSON.stringify(err)));
Comment thread
jakequade-pc marked this conversation as resolved.
Outdated
err.context = er;
throw err; // Unhandled 'error' event
}
Expand Down Expand Up @@ -498,4 +498,4 @@ function eventTargetAgnosticAddListener(emitter, name, listener, flags) {
} else {
throw new TypeError('The "emitter" argument must be of type EventEmitter. Received type ' + typeof emitter);
}
}
}
Loading