Skip to content

Set ContentDir when TestConfig is created #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuumasato wants to merge 1 commit into from
Closed

Set ContentDir when TestConfig is created #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func NewTestConfig() *TestConfig {
Product: product,
Platform: platform,
ContentImage: contentImage,
ContentDir: "", // Will be set during setup
ContentDir: contentDir,
Copy link
Copy Markdown
Collaborator

@rhmdnd rhmdnd Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't I already setting that in https://github.com/ComplianceAsCode/ocp4e2e/pull/61/files#diff-fe44f09c4d5977b5f5eaea29170b6a0748819c9d02271746a20d81a5f3efca17R74?

Copy link
Copy Markdown
Member Author

@yuumasato yuumasato Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are, so that is likely not the root cause of manual remediations not being run

Copy link
Copy Markdown
Member Author

@yuumasato yuumasato Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your PR, and this PR, both probably solve content-dir for openshift/release#69497.
But don't explain why the manual remediation is not working.

LogDir: logDir,
InstallOperator: installOperator,
BypassRemediations: bypassRemediations,
Expand Down