Skip to content

chore!: removal of HiddenText#3361

Open
LinKCoding wants to merge 3 commits into
mainfrom
kl-gmt-1625-gamut-hiddentext
Open

chore!: removal of HiddenText#3361
LinKCoding wants to merge 3 commits into
mainfrom
kl-gmt-1625-gamut-hiddentext

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented May 29, 2026

Overview

Removes the deprecated HiddenText component from @codecademy/gamut. HiddenText was already marked @deprecated in favor of <Text screenreader>

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1625
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Turn on VO
  2. Go to: ConnectedFormGroup (/?path=/story/organisms-connectedform-connectedformgroup--default) set hideLabel to true and check that VO still announces the label
  3. Go to: ConnectedForm SubmitButton (/?path=/story/organisms-connectedform-submitbutton--states) check that the loading button still announces "loading"
  4. Go to a story (/?path=/story/organisms-gridform-buttons--submit-button-inline) check that the hidden label still announces "Simple text" (NOTE: I will remove this test code before merging)
  5. ...
  6. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 29, 2026

View your CI Pipeline Execution ↗ for commit 30a6654


☁️ Nx Cloud last updated this comment at 2026-06-01 20:48:03 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@LinKCoding LinKCoding force-pushed the kl-gmt-1625-gamut-hiddentext branch from 80066e2 to 30a6654 Compare June 1, 2026 20:20
@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 70.0.1-alpha.cbad11.0 npm diff
@codecademy/gamut-icons 9.57.8-alpha.cbad11.0 npm diff
@codecademy/gamut-illustrations 0.58.14-alpha.cbad11.0 npm diff
@codecademy/gamut-kit 1.0.1-alpha.cbad11.0 npm diff
@codecademy/gamut-patterns 0.10.33-alpha.cbad11.0 npm diff
@codecademy/gamut-styles 20.0.1-alpha.cbad11.0 npm diff
@codecademy/gamut-tests 6.0.4-alpha.cbad11.0 npm diff
@codecademy/variance 0.26.2-alpha.cbad11.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.cbad11.0 npm diff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

@LinKCoding LinKCoding marked this pull request as ready for review June 3, 2026 13:17
@LinKCoding LinKCoding requested a review from a team as a code owner June 3, 2026 13:17
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants