Fix token leak to other cluster during forced node add #1142
Merged
Conversation
Assissted by: ClaudeCode
I figured it doesnt make sense to have some tests in fluent and other tests in non fluent interface within one test class. So I converted whole classes to fluent interface.
ApetorSkol
temporarily deployed
to
testing-farm-apikey
GitHub Actions
Inactive
tomjelinek
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using pcs cluster node add ... --force on a node that is already in cluster, it leaks the auth tokens to other nodes in cluster. To not share this info, cluster is destroyed before joining new cluster.