Skip to content

security: fix SSRF and URL validation in event importer #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BreakableHoodie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

security: fix SSRF and URL validation in event importer #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c9d3c
security: fix SSRF and URL substring sanitization in openai.js
BreakableHoodie Jun 10, 2026
46cb70e
security: fix endsWith hostname checks to prevent subdomain bypass
BreakableHoodie Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 43 additions & 25 deletions integrations/openai.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,27 +21,44 @@ const openai = new OpenAI({
apiKey: process.env.OPENAI_API_KEY,
});

function getExtractor(url) {
if (url.includes('eventbrite.com') || url.includes('eventbrite.ca')) {
return eventbriteExtractor;
}
if (url.includes('meetup.com')) {
return meetupExtractor;
}
if (url.includes('explorewaterloo.ca')) {
return exploreWaterlooExtractor;
}
if (url.includes('calendar.waterlooregionmuseum.ca')) {
return waterlooRegionMuseumExtractor;
}
if (url.includes('calendar.kitchener.ca')) {
return cityOfKitchenerExtractor;
}
if (url.includes('events.cambridge.ca')) {
return cityOfCambridgeExtractor;
function isValidPublicUrl(url) {
try {
const { protocol, hostname } = new URL(url);
if (!['http:', 'https:'].includes(protocol)) return false;
if (/^(localhost|127\.0\.0\.1|::1|0\.0\.0\.0)$/.test(hostname)) return false;
if (/^(10\.|172\.(1[6-9]|2[0-9]|3[01])\.|192\.168\.|169\.254\.)/.test(hostname)) return false;
return true;
} catch {
return false;
}
if (url.includes('events.waterloo.ca')) {
return cityOfWaterlooExtractor;
}

function getExtractor(url) {
try {
const { hostname } = new URL(url);
if (hostname === 'eventbrite.com' || hostname.endsWith('.eventbrite.com') || hostname === 'eventbrite.ca' || hostname.endsWith('.eventbrite.ca')) {
return eventbriteExtractor;
}
if (hostname === 'meetup.com' || hostname.endsWith('.meetup.com')) {
return meetupExtractor;
}
if (hostname === 'explorewaterloo.ca' || hostname.endsWith('.explorewaterloo.ca')) {
return exploreWaterlooExtractor;
}
if (hostname === 'calendar.waterlooregionmuseum.ca') {
return waterlooRegionMuseumExtractor;
}
if (hostname === 'calendar.kitchener.ca') {
return cityOfKitchenerExtractor;
}
if (hostname === 'events.cambridge.ca') {
return cityOfCambridgeExtractor;
}
if (hostname === 'events.waterloo.ca') {
return cityOfWaterlooExtractor;
}
} catch {
return null;
}
return null;
}
Expand All @@ -52,13 +69,14 @@ export const importEventFromUrl = async (url) => {
return { error: 'URL is required' };
}

if (url.includes('facebook.com/events')) {
return { error: 'Facebook events are not supported, please use the event form.' };
if (!isValidPublicUrl(url)) {
return { error: 'Invalid or unsupported URL.' };
}

if (url.includes('instagram.com/')) {
return { error: 'Instagram posts are not supported, please use the event form.' };
}
try { const { hostname } = new URL(url);
if (hostname === 'facebook.com' || hostname.endsWith('.facebook.com')) return { error: 'Facebook events are not supported, please use the event form.' };
if (hostname === 'instagram.com' || hostname.endsWith('.instagram.com')) return { error: 'Instagram posts are not supported, please use the event form.' };
} catch { return { error: 'Invalid URL.' }; }

// Fetch the webpage content
const response = await fetch(url);
Expand Down