Skip to content

Custom packets for ItemExchange trade displays - #965

Open
Protonull wants to merge 5 commits into
CivMC:mainfrom
Protonull:ie-mod-support
Open

Custom packets for ItemExchange trade displays#965
Protonull wants to merge 5 commits into
CivMC:mainfrom
Protonull:ie-mod-support

Conversation

@Protonull

Copy link
Copy Markdown
Contributor

This allows for mods like TradeX to more accurately track shop chests and their offerings.

This allows for mods like TradeX to more accurately track shop chests and their offerings.
@okx-code

okx-code commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hey gson is thread safe (mentioned in the navadocs) so you don't need to synchronise on it

@okx-code

okx-code commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Also with the namespacedkey I feel like it's a lot of complexity to handle this memoisation, is there a way to reduce it? Perhaps hardcoding the plugin name or dependency injecting it.

@Protonull

Copy link
Copy Markdown
Contributor Author

Also with the namespacedkey I feel like it's a lot of complexity to handle this memoisation, is there a way to reduce it?

It's probably just class-loading neurosis on my part, but I fret over these kinds of static fields which are set upon class initialisation, which could potentially happen prior to ItemExchangePlugin's constructor being called and its instance field set. I'm probably fretting over nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants