feat(apps): discord forks - #1361
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesDiscord client installers
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant main
participant Installer
participant PackageManager
User->>main: select Discord client
main->>Installer: invoke selected installer
Installer->>PackageManager: install package for detected system
PackageManager-->>Installer: return installation result
Installer-->>main: complete installation
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
core/tabs/applications-setup/communication-apps/discord-setup.sh (1)
48-48: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winAdd timeouts to the new curl calls. None of the curl invocations added for Vesktop and Equibop installation set a timeout. A stalled connection to
vencord.devorapi.github.comblocks the interactive installer indefinitely with no feedback to the user.
core/tabs/applications-setup/communication-apps/discord-setup.sh#L48-L48: add--connect-timeout/--max-timetocurl -fLo vesktop.deb "$VESKTOP_DEB_URL".core/tabs/applications-setup/communication-apps/discord-setup.sh#L78-L78: add the same timeout flags to the GitHub API lookup in the apt-get branch ofinstallEquibop.core/tabs/applications-setup/communication-apps/discord-setup.sh#L89-L89: add the same timeout flags tocurl -fLo equibop.deb "$EQUIBOP_DEB_URL".core/tabs/applications-setup/communication-apps/discord-setup.sh#L98-L98: add the same timeout flags to the GitHub API lookup in the dnf branch ofinstallEquibop.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/tabs/applications-setup/communication-apps/discord-setup.sh` at line 48, Update the Vesktop and Equibop download/API curl invocations in core/tabs/applications-setup/communication-apps/discord-setup.sh at lines 48, 78, 89, and 98 to include both connection and overall execution timeouts, covering the calls in the Vesktop flow and installEquibop apt-get and dnf branches.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/tabs/applications-setup/communication-apps/discord-setup.sh`:
- Around line 42-45: Update the architecture-selection case blocks in the
apt-get|nala and dnf branches to handle unsupported $ARCH values by leaving the
URL unset, then validate VESKTOP_DEB_URL or VESKTOP_RPM_URL before invoking curl
or the package installer. Follow the existing installEquibop validation pattern
to print a clear unsupported-architecture error and exit instead of attempting
installation with an empty URL.
- Line 124: Update the Equicord menu label in the setup script’s printf
statement to use a single space between “Equicord” and “(Vesktop with more
plugins)”, preserving the rest of the text unchanged.
---
Nitpick comments:
In `@core/tabs/applications-setup/communication-apps/discord-setup.sh`:
- Line 48: Update the Vesktop and Equibop download/API curl invocations in
core/tabs/applications-setup/communication-apps/discord-setup.sh at lines 48,
78, 89, and 98 to include both connection and overall execution timeouts,
covering the calls in the Vesktop flow and installEquibop apt-get and dnf
branches.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 70c972c3-4550-4aaa-9e99-921f9e53a12b
📒 Files selected for processing (1)
core/tabs/applications-setup/communication-apps/discord-setup.sh
ChrisTitusTech
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
So, I asked in Discord, got a green light and done it. When Discord is selected, it shows choice of 3 - vanilla, Vesktop and Equibop. Selection mechanic was stolen from auto-cpufreq file, all the installation script were written by Sonnet, cause I'm lazy to search. Also I named Equibop wrong, since Equicord is a core of Equibop, whoops, won't change it, too lazy xd
Arch works fine, maybe needed to test RPM and DEB packages, just to be sure, but looks fine.
Screenshots (if applicable)