Fix sonar issues for server/recCeiver (only)#157
Open
anderslindho wants to merge 15 commits intomasterfrom
Open
Fix sonar issues for server/recCeiver (only)#157anderslindho wants to merge 15 commits intomasterfrom
anderslindho wants to merge 15 commits intomasterfrom
Conversation
anderslindho
force-pushed
the
fix-sonar-issues
branch
4 times, most recently
from
553a340 to
331cc71
Compare
anderslindho
force-pushed
the
fix-sonar-issues
branch
from
331cc71 to
9d51918
Compare
|
jacomago
reviewed
May 8, 2026
| return [ | ||
| channel | ||
| for channel in self.cf.values() | ||
| if any(prop["name"] == "pvStatus" and prop["value"] == "Active" for prop in channel["properties"]) |
Contributor
There was a problem hiding this comment.
use enums for some of these. Would be good to split up cfstore into
- cfstore
- store (actual processors)
- recc_cf_client (all methods used to push to cf)
- model (conversion between types, and types)
or something. then can import from model maybe.
Contributor
Author
There was a problem hiding this comment.
You do realise that I am doing the bare minimum to get our sonar score better, right?
Contributor
There was a problem hiding this comment.
I move mean you can import from cfstore to get the "Active". so this would be simpler.
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install . | ||
| python - <<'PY' |
Contributor
There was a problem hiding this comment.
this feels ugly, couldn't it be simpler in pure bash?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.