fix(teams): support single-tenant bots via TEAMS_APP_TENANT_ID env var#2928
Open
xodn348 wants to merge 1 commit into
Open
fix(teams): support single-tenant bots via TEAMS_APP_TENANT_ID env var#2928xodn348 wants to merge 1 commit into
xodn348 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BotFrameworkAdapterSettingsnow receiveschannel_auth_tenantfrom theTEAMS_APP_TENANT_IDenvironment variable, enabling single-tenant Azure Bot registrations.TEAMS_APP_TENANT_IDis unset the value isNone, preserving the existing multi-tenant behaviour.Related issue
Closes #2919 — MS Teams integration supports only deprecated multi tenant bots
Local verification
Risk
Low. One-line change; the new parameter is optional and defaults to
None(same as the previous implicit default). No behaviour change for existing multi-tenant deployments.Summary by cubic
Enable single-tenant Microsoft Teams bots by wiring
TEAMS_APP_TENANT_IDtoBotFrameworkAdapterSettings.channel_auth_tenant(closes #2919). When unset, behavior stays multi-tenant; tests cover both paths.Written for commit 1c86d64. Summary will update on new commits. Review in cubic