Skip to content

fix: unconditional hook calls in ChatProfiles and FeedbackButtons #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EyalAmitay wants to merge 3 commits into
base: main
Choose a base branch
from
+200 −17
Open

fix: unconditional hook calls in ChatProfiles and FeedbackButtons #2912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3a820d
fix: move hooks above early returns in ChatProfiles and FeedbackButtons
EyalAmitay Apr 26, 2026
3d425bc
test(frontend): add regression tests for hooks-order fix in ChatProfi…
EyalAmitay Apr 27, 2026
11161d6
test(frontend): fix hook-error regex to match React's exact invariant…
EyalAmitay Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/src/components/chat/Messages/Message/Buttons/FeedbackButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ export function FeedbackButtons({ message }: FeedbackButtonsProps) {
const firstInteraction = useRecoilValue(firstUserInteraction);
const { idToResume } = useChatSession();

if (!showFeedbackButtons) {
return null;
}

const handleFeedbackChange = useCallback(
(newFeedback?: number, newComment?: string) => {
if (newFeedback === undefined) {
Expand Down Expand Up @@ -97,6 +93,10 @@ export function FeedbackButtons({ message }: FeedbackButtonsProps) {

const isDisabled = message.streaming || !(firstInteraction || idToResume);

if (!showFeedbackButtons) {
return null;
}

return (
<div className="flex items-center">
<TooltipProvider>
Expand Down
28 changes: 15 additions & 13 deletions frontend/src/components/header/ChatProfiles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,29 +41,31 @@ export default function ChatProfiles({ navigate }: Props) {
const [newChatProfile, setNewChatProfile] = useState<string | null>(null);
const [openDialog, setOpenDialog] = useState(false);

// Early return check to prevent unnecessary renders and resource waste
if (!config?.chatProfiles?.length || config.chatProfiles.length <= 1) {
return null;
}
const profiles = config?.chatProfiles;
const hasMultipleProfiles = !!profiles && profiles.length > 1;

// Handle case when no profile is selected
// Auto-select the first profile when none is selected
useEffect(() => {
if (!chatProfile) {
setChatProfile(config.chatProfiles[0].name);
if (hasMultipleProfiles && !chatProfile) {
setChatProfile(profiles![0].name);
}
}, [chatProfile, config.chatProfiles, setChatProfile]);
}, [hasMultipleProfiles, chatProfile, profiles, setChatProfile]);

// Handle case when selected profile becomes invalid
// Reset to first profile when the current selection becomes invalid
useEffect(() => {
if (chatProfile) {
const profileExists = config.chatProfiles.some(
if (hasMultipleProfiles && chatProfile) {
const profileExists = profiles!.some(
(profile) => profile.name === chatProfile
);
if (!profileExists) {
setChatProfile(config.chatProfiles[0].name);
setChatProfile(profiles![0].name);
}
}
}, [chatProfile, config.chatProfiles, setChatProfile]);
}, [hasMultipleProfiles, chatProfile, profiles, setChatProfile]);

if (!hasMultipleProfiles) {
return null;
}

const handleClose = () => {
setOpenDialog(false);
Expand Down