Skip to content

[ENG-10943] Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response #11719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 2 commits into from
May 1, 2026
Merged

[ENG-10943] Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response #11719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad4d546
Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' …
Ostap-Zherebetskyi Apr 30, 2026
f9831e6
Add assertions for 'id' and 'event_name' in subscription detail respo…
Ostap-Zherebetskyi May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/subscriptions/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,9 @@ def update(self, request, *args, **kwargs):
raise PermissionDenied

for instance in qs:
instance.legacy_id = self.kwargs['subscription_id']
instance.event_name = instance.notification_type.name

serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
serializer.is_valid(raise_exception=True)
self.perform_update(serializer)
Expand All @@ -326,6 +329,9 @@ def update(self, request, *args, **kwargs):
raise PermissionDenied

for instance in qs:
instance.legacy_id = self.kwargs['subscription_id']
instance.event_name = instance.notification_type.name

serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
serializer.is_valid(raise_exception=True)
self.perform_update(serializer)
Expand Down Expand Up @@ -354,13 +360,17 @@ def update(self, request, *args, **kwargs):
raise PermissionDenied

for instance in qs:
instance.legacy_id = self.kwargs['subscription_id']
instance.event_name = instance.notification_type.name

serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
serializer.is_valid(raise_exception=True)
self.perform_update(serializer)
return Response(serializer.data)

else:
instance.event_name = instance.notification_type.name # Set event_name for serializer to use
instance.legacy_id = instance.notification_type.name # Set legacy_id for serializer to use

partial = kwargs.pop('partial', False)
serializer = self.get_serializer(instance, data=request.data, partial=partial)
Expand Down
2 changes: 2 additions & 0 deletions api_tests/subscriptions/views/test_subscriptions_detail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,3 +342,5 @@ def test_subscription_detail_patch(
res = app.patch_json_api(url_user_global_file_updated, payload, auth=user.auth)
assert res.status_code == 200
assert res.json['data']['attributes']['frequency'] == 'none'
assert res.json['data'].get('id') is not None
assert res.json['data']['attributes'].get('event_name') is not None
Loading