[ENG-10775] Move notification management from admin/admin to badmin and improve template preview#11715
Merged
cslzchen merged 3 commits intoCenterForOpenScience:feature/pbs-26-9from May 1, 2026
Conversation
…s for notifications management
cslzchen
approved these changes
Apr 27, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
⭐ Looks great!!! This is impressive work.
Optionally, let's take a look at how to provide more information on fail-to-render templates due to complex dict list/loop so that PO / SE knows what to modify in the mock JSON to display it correctly.
…data support in preview
Ostap-Zherebetskyi
changed the base branch from
feature/pbs-26-6
to
feature/pbs-26-9
cslzchen
changed the title
cslzchen
merged commit b985424
into
CenterForOpenScience:feature/pbs-26-9
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
See diff
Side Effects
N/A
QE Notes
N/A
CE Notes
N/A
Documentation
N/A