Repository navigation
fix(security): block grants when existing directory assignments are unverifiable - #56
Merged
Merged
Conversation
… existing principals
…rants while preserving revocations
…revoke regression
…-duties fail-closed
27 of 37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap and root cause
P4 directory/SoD reliability.
Policy.Plan(GrantAccess)previously validated the requested target and groups present in the current snapshot. If an existing group assignment was omitted from that snapshot, the group was never checked andEffectiveRoleIdstreated its effective access as nonexistent. A new role could therefore bypass separation-of-duties calculations even though Keycloak may still enforce the prior group mapping.UpdateRolealso previously resolved existing assigned identities by local ID without a same-realm uniqueness check.Changes
GrantAccessorUpdateRole.RevokeAccessduring directory incidents: do not require this additional visibility gate for entitlement removal.Acceptance
.NET build + xUnit + PostgreSQL, ASP.NET API HTTP, live Keycloak/LDAP, worker recovery, OIDC, accessibility, and other applicable PR checks at the exact PR head.