SAE feature coactivation analysis#3
Open
JuiceB0xC0de wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for adding this! Reviewing today and will pull shortly |
bryceag11
reviewed
Jun 10, 2026
bryceag11
left a comment
Contributor
There was a problem hiding this comment.
Co-firing fills a gap, and I ran it on SmolVLA / X-VLA / Pi0.5 / OpenVLA-OFT & it runs clean across all four! Just some cleanups:
load_sae_checkpointis a verbatim copy of the one inconcept_id.py, import it instead of duplicating.- Drop the unused
get_concept_task_mappingimport co_fire_rateis the partner's marginal fire rate, not the joint rate, id consider renaming- Line 137 throws a divide-by-zero warning on sparse models (pi05/oft) so use
np.divide(inter, union, out=np.zeros_like(inter), where=union > 0).
Optional: raw Jaccard gets dominated by always-on features (one feature topped 4 unrelated concepts on Pi0.5) so a lift/PMI metric or base-rate filter would sharpen it. And a one-line experiments/README.md entry would be great!
Looks good after those changes ill merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yo I've been messing around with SAE atlasing for a minute and figured you might want some extra action for the atlas.