You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to evaluate the gain, and took tangential_relaxation(mesh) expecting it to be a low hanging fruit. To my surprise it becomes 20% slower, without that I understand yet what happens. As the Hilbert sort sorts the polygon soup
I checked that the vertices./faces/halfedges of the generated Surface_mesh are also sorted. I then was wondering if tangential relaxation depends on the order, but it does not modify positions while iterating over the vertices, but per round.
As a side remark, tangential_relaxation(mesh) uses a std::unordered_map as property map for vertices and faces. This makes sense if it does on a subset of vertices. Otherwise a dynamic property map would be a better choice.
As explained here Hilbert sorting only guarantees that what is close in the sorted sequence is also geometrically close, but not the other way round. I added a benchmrk that only calls faces_around_target() for all vertices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add
CGAL::Polygon_mesh_processing::hilbert_sort_polygon_soup()Todo
Release Management