You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#236. Test cases 367 and 370 carried the same compact JWS as valid test case 357, so their invalidBase64Padding labels did not match the encoded input.
Change
Add forbidden Base64 padding to the signature segment in test case 367.
Add forbidden Base64 padding to the payload segment in test case 370 and recompute its HMAC-SHA256 signature over the padded payload.
Verification
GOEXPERIMENT=jsonv2 go run ./tools/vectorgen fmt --check 'testvectors_v1/*.json' — passed.
GOEXPERIMENT=jsonv2 go run ./tools/vectorgen lint — passed: 343 valid vector files, 0 invalid, 0 without a schema.
Independent HMAC-SHA256 checks confirmed the corrected signature bytes match the respective JWS signing inputs.
I rebased the commit onto current main; the stable patch-id is unchanged and git diff --check passes. The latest run has vectorlint, gostaticcheck, and golint green; govulncheck fails on GO-2026-6809 in the Go standard library (crypto/x509 in Go 1.27.2), reached from tools/vectorgen/main.go. Could you confirm whether that repository-level toolchain finding should stay outside this test-vector change?
Rebased codex/fix-jws-padding-vectors-236 onto current upstream main, including merged #283 (d17cc89). The patch-id remains unchanged (95e99ff), and git diff --check passed. GitHub has started a fresh run; govulncheck and the other checks are currently pending.
I rebased onto current main with #283; govulncheck, gostaticcheck, golint, and vectorlint all pass on 7db7db3. Please let me know if anything else is needed, or merge when convenient.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #236. Test cases 367 and 370 carried the same compact JWS as valid test case 357, so their
invalidBase64Paddinglabels did not match the encoded input.Change
Verification
GOEXPERIMENT=jsonv2 go run ./tools/vectorgen fmt --check 'testvectors_v1/*.json'— passed.GOEXPERIMENT=jsonv2 go run ./tools/vectorgen lint— passed: 343 valid vector files, 0 invalid, 0 without a schema.git diff --check— passed.