Skip to content

Add SPKI and PKCS8 inputs for ML-DSA #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpu merged 2 commits into from
Oct 23, 2025
Merged

Add SPKI and PKCS8 inputs for ML-DSA #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0730a6
Add SPKI and PKCS8 inputs for ML-DSA
davidben Oct 17, 2025
e3fc7ae
Update ML-DSA verify schemas
davidben Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions schemas/mldsa_sign_seed_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
"format": "HexBytes",
"description": "32-byte seed that generated the private key"
},
"privateKeyPkcs8": {
"type": "string",
"format": "Der",
"description": "Private key as a DER-encoded PrivateKeyInfo, using the seed form"
},
"tests": {
"type": "array",
"items": {
Expand Down
24 changes: 20 additions & 4 deletions schemas/mldsa_verify_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@
"type": {
"enum": ["MlDsaVerify"]
},
"public_key": {
"publicKey": {
Comment thread
cpu marked this conversation as resolved.
Resolved
"type": "string",
"format": "HexBytes",
"description": "Encoded ML-DSA public key"
},
"publicKeyDer": {
"type": "string",
"format": "Der",
"description": "Public key as a DER-encoded SubjectPublicKeyInfo"
},
"tests": {
"type": "array",
"items": {
Expand All @@ -21,7 +26,9 @@
"source": {
"$ref": "common.json#/definitions/Source"
}
}
},
"additionalProperties": false,
"required": ["type", "publicKey", "publicKeyDer", "tests"]
},
"MlDsaVerifyTestVector": {
"type": "object",
Expand Down Expand Up @@ -61,14 +68,21 @@
},
"description": "A list of flags"
}
}
},
"additionalProperties": false,
"required": ["tcId", "comment", "msg", "sig", "flags"]
}
},
"properties": {
"algorithm": {
"type": "string",
"description": "the primitive tested in the test file"
},
"generatorVersion": {
"type": "string",
"description": "DEPRECATED: prefer \"source\" property in test group",
"deprecated": true
},
"header": {
"type": "array",
"items": {
Expand All @@ -92,5 +106,7 @@
"$ref": "#/definitions/MlDsaVerifyTestGroup"
}
}
}
},
"additionalProperties": false,
"required": ["algorithm", "header", "notes", "numberOfTests", "schema", "testGroups"]
}
9 changes: 9 additions & 0 deletions testvectors_v1/mldsa_44_sign_seed_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{
"type": "MlDsaSign",
"privateSeed": "2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280202a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down Expand Up @@ -583,6 +584,7 @@
{
"type": "MlDsaSign",
"privateSeed": "0100000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280200100000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down Expand Up @@ -626,6 +628,7 @@
{
"type": "MlDsaSign",
"privateSeed": "ff19000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031104228020ff19000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -647,6 +650,7 @@
{
"type": "MlDsaSign",
"privateSeed": "ce05000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031104228020ce05000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -668,6 +672,7 @@
{
"type": "MlDsaSign",
"privateSeed": "1f00000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280201f00000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -689,6 +694,7 @@
{
"type": "MlDsaSign",
"privateSeed": "002a010000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031104228020002a010000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -710,6 +716,7 @@
{
"type": "MlDsaSign",
"privateSeed": "6d07010000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280206d07010000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -731,6 +738,7 @@
{
"type": "MlDsaSign",
"privateSeed": "0600000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280200600000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -752,6 +760,7 @@
{
"type": "MlDsaSign",
"privateSeed": "0d00000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040311042280200d00000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down
15 changes: 15 additions & 0 deletions testvectors_v1/mldsa_44_verify_test.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions testvectors_v1/mldsa_65_sign_seed_test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{
"type": "MlDsaSign",
"privateSeed": "2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a",
"privateKeyPkcs8": "3034020100300b0609608648016503040312042280202a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a2a",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down Expand Up @@ -627,6 +628,7 @@
{
"type": "MlDsaSign",
"privateSeed": "0100000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040312042280200100000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down Expand Up @@ -659,6 +661,7 @@
{
"type": "MlDsaSign",
"privateSeed": "ff19000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031204228020ff19000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -680,6 +683,7 @@
{
"type": "MlDsaSign",
"privateSeed": "8804000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040312042280208804000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -701,6 +705,7 @@
{
"type": "MlDsaSign",
"privateSeed": "093a000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031204228020093a000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down Expand Up @@ -733,6 +738,7 @@
{
"type": "MlDsaSign",
"privateSeed": "4291000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040312042280204291000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -754,6 +760,7 @@
{
"type": "MlDsaSign",
"privateSeed": "b020000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b060960864801650304031204228020b020000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand All @@ -775,6 +782,7 @@
{
"type": "MlDsaSign",
"privateSeed": "0600000000000000000000000000000000000000000000000000000000000000",
"privateKeyPkcs8": "3034020100300b0609608648016503040312042280200600000000000000000000000000000000000000000000000000000000000000",
"source": {
"name": "github/gendx",
"version": "0.1"
Expand Down
Loading