Skip to content

refactor(clips): render clean video filmstrip - #2558

Merged
steve8708 merged 4 commits into
BuilderIO:mainfrom
shivanshu11092003:film-strips
Aug 3, 2026
Merged

refactor(clips): render clean video filmstrip#2558
steve8708 merged 4 commits into
BuilderIO:mainfrom
shivanshu11092003:film-strips

Merge remote-tracking branch 'origin/main' into film-strips

5211372
Select commit
Loading
Failed to load commit list.
Builder.io Integration / Review Agent completed Jul 31, 2026 in 6m 49s

1 potential issue found

Incremental Code Review Summary

The latest code still preserves the previously open trim-visibility, trim-drag bubbling, and high-zoom thumbnail aspect-ratio comments; I did not repost them. The upload-race cleanup and concurrent replacement guards remain present. The new duration cap keeps logical track sizing bounded, but the backing-store clamp introduces a separate rendering problem: canvas drawing still uses full logical coordinates while the bitmap is capped, so overlays and waveform content are clipped/stretched on wide tracks.

I did not report the migration concern or hardcoded constant duplication as actionable: Clips has the additive-column startup safety net, and the duplicated values currently match without a user-facing defect.

New Finding

  • 🟡 MEDIUM — The canvas backing-store width is capped without scaling the drawing coordinate system, causing wide-track waveform/selection overlays to clip or blur while the DOM canvas remains full width.

🧪 Browser testing: Will run after this review (PR touches UI code)