-
Notifications
You must be signed in to change notification settings - Fork 404
Improve large Content database performance #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3mdistal
wants to merge
20
commits into
BuilderIO:main
Choose a base branch
from
3mdistal:codex/content-large-database-performance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d8e886f
Improve large Content database performance
3mdistal d07d402
Fix exact Content mutation projections
3mdistal 03c1a6f
Record blocked Content performance landing
3mdistal 59409da
Fix nested GET action parameters
3mdistal b95ceb0
Avoid redundant Builder field backfills
3mdistal 1d2dca3
Project Builder source fields on reveal
3mdistal b0c28b1
Paint Builder source columns optimistically
3mdistal 57be73a
Avoid duplicate Builder field scans
3mdistal e717fdb
Cover large Builder field reveals
3mdistal 83c4582
Finish Builder imports in one continuation
3mdistal 46ffed6
Resume full Builder syncs from their cursor
3mdistal 212c4e8
Record hosted large-table acceptance
3mdistal f006d6a
Improve large Builder database loading
3mdistal 748688f
Satisfy content performance checks
3mdistal ccaa7b7
Complete Builder metadata and bodies sooner
3mdistal e7415e7
Localize Builder attach preview status
3mdistal 06af498
Batch Builder body hydration reads
3mdistal a2fced0
Finish bounded large database reads
3mdistal 560ed09
Stabilize Builder attach preview and hydration claims
3mdistal a9e72b0
Bulk persist pristine Builder bodies
3mdistal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@agent-native/core": patch | ||
| --- | ||
|
|
||
| Preserve nested object parameters when browser clients call GET actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { processWithConcurrency } from "./_batch-utils.js"; | ||
|
|
||
| describe("processWithConcurrency", () => { | ||
| it("starts the next item as soon as one worker becomes available", async () => { | ||
| const releases = new Map<number, () => void>(); | ||
| const started: number[] = []; | ||
| const run = processWithConcurrency([1, 2, 3, 4], 2, async (item) => { | ||
| started.push(item); | ||
| await new Promise<void>((resolve) => releases.set(item, resolve)); | ||
| }); | ||
|
|
||
| await expect.poll(() => started).toEqual([1, 2]); | ||
| releases.get(1)?.(); | ||
| await expect.poll(() => started).toEqual([1, 2, 3]); | ||
| releases.get(3)?.(); | ||
| await expect.poll(() => started).toEqual([1, 2, 3, 4]); | ||
| releases.get(2)?.(); | ||
| releases.get(4)?.(); | ||
|
|
||
| await run; | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Preserve non-plain GET parameter values
This branch JSON-serializes every object, including
DateandURLSearchParams. A Date now arrives JSON-quoted instead of in its prior parseable string form, while URLSearchParams serializes to{}and loses its entries; restrict this path to plain records and retain the existing string conversion for other object types.Additional Info