Skip to content

[BI-2908] Remove cache.get() dependencies from BrAPIObservationDAO#531

Merged
humsika merged 3 commits into
bug/BI-2944from
feature/BI-2908
Jul 8, 2026
Merged

[BI-2908] Remove cache.get() dependencies from BrAPIObservationDAO#531
humsika merged 3 commits into
bug/BI-2944from
feature/BI-2908

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Jul 6, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Story: BI-2908

Replaced programCache.get() in ObservationDAO with BrAPI GET call.

The max amount of observations retrieved by this call will be the allowed maximum from the CACHE_BRAPI_FETCH_PAGE_SIZE=65000 variable in .env

This should be enough for now, until optimizations are made to some code via other tickets created, like BI-2961, BI-2963 and BI-2964

Dependencies

Testing

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@jloux-brapi
Add TODOs for cache.get() path involving trial deletion
2896356
@jloux-brapi
Remove cache.get calls from ObservationDAO
2d3d39c 
- Create tickets for optimizations and improvements to downstream usages of these calls and mark with TODOs
@jloux-brapi jloux-brapi changed the title Feature/bi 2908 [BI-2908] Remove cache.get() dependencies from BrAPIObservationDAO Jul 6, 2026
@jloux-brapi jloux-brapi requested review from a team and humsika and removed request for a team July 6, 2026 22:56
@jloux-brapi jloux-brapi added the on hold Review, but do not merge until removed label Jul 6, 2026
humsika
humsika reviewed Jul 7, 2026
View reviewed changes
Comment thread src/main/java/org/breedinginsight/brapi/v2/dao/BrAPIObservationDAO.java Outdated
humsika
humsika reviewed Jul 7, 2026
View reviewed changes
Comment thread src/main/java/org/breedinginsight/brapi/v2/dao/BrAPIObservationDAO.java Outdated
@humsika

humsika commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code looks good to me and is working as expected.

@humsika humsika merged commit e07a755 into bug/BI-2944 Jul 8, 2026
1 check passed
@humsika humsika deleted the feature/BI-2908 branch July 8, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humsika humsika humsika left review comments

Assignees

No one assigned

Labels

feature on hold Review, but do not merge until removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jloux-brapi @humsika