rangeproof: initial set of cleanups, minor stack space improvements#150
Open
apoelstra wants to merge 7 commits intoBlockstreamResearch:masterfrom
Open
rangeproof: initial set of cleanups, minor stack space improvements#150apoelstra wants to merge 7 commits intoBlockstreamResearch:masterfrom
apoelstra wants to merge 7 commits intoBlockstreamResearch:masterfrom
Conversation
Add two new fixed rangeproof vectors; check that various extracted values are correct; add a test for creating and verifying single-value proofs.
This decreases rangeproof proving stack size by 224 bytes on my system. Though the point is not to show large stack reductions (yet) but to demo the closure API on something simple/non-invasive. Future commits will use this for scalars and public keys, and then we will see some serious stack reduction.
Reduces stack usage of rangeproof_sign by 1056 bytes, is a bit safer as it doesn't require the caller of borromean_sign to know which indices are going to be overwritten, is a net-negative code diff, and will simplify things for the next step of closure-ification.
apoelstra
force-pushed
the
2021-10--initial-rangeproof-cleanups
branch
4 times, most recently
from
f708890 to
3f23126
Compare
This is purely to reduce the number of arguments being passed into one function at once. Also improves const-correctness.
apoelstra
force-pushed
the
2021-10--initial-rangeproof-cleanups
branch
from
3f23126 to
6c94f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #149