Add ecdsa adaptor#11
Conversation
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
3 times, most recently
from
3becc42 to
9658de2
Compare
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Tibo-lg!
Definitely most welcome :)
I've left some comments regarding naming, unsafe-block size and very importantly: panic behaviour.
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
from
9658de2 to
2202709
Compare
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks for working in the comments and adding all these tests!
I've left some more feedback. Everything related to the tests is more of a nit though !
@jonasnick Can you also have a look at this please?
|
Confirmed that 7637c2e is the result of vendoring BlockstreamResearch/secp256k1-zkp@f3708a1. |
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
3 times, most recently
from
55df7d2 to
0229236
Compare
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you!
Just one more typo in the docs!
Otherwise happy to merge this.
I'll give @jonasnick a couple of days in case he wants to have a look as well!
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
from
0229236 to
1830ec6
Compare
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
Very nice!
ACK mod nits
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
from
1830ec6 to
e009a51
Compare
Tibo-lg
force-pushed
the
add-ecdsa-adaptor
branch
from
e009a51 to
309bbb4
Compare
|
Rebased on a7409c9 |
|
tACK 309bbb4 Verified locally that f9b8dc7 just vendors BlockstreamResearch/secp256k1-zkp@f3708a1 and does nothing else. |
|
ACK 309bbb4 |
3 participants
As ECDSA adaptor signatures PR has been merged upstream (BlockstreamResearch/secp256k1-zkp#117) I tried to port the code I had for them in a fork of rust-secp256k1 here (hoping that it could be useful to others).