Repository navigation
fix(ui): persist GitHub provider trigger selection - #39
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth GitHub provider forms now ignore empty trigger-type selections. Valid selections continue to update form state. ChangesTrigger selection handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Integrates upstream Dokploy commit
15bc4b5dcfromDokploy/dokploy:canary(upstream tipbb73c6e6d). The GitHub application and Compose provider forms now keep trigger type as a controlled field, so a saved provider selection remains visible after loading persisted values.Integration review
5df820a740..bb73c6e6d; substantive change:15bc4b5dc.Verification
pnpm install --frozen-lockfile(pass; Node 24.13.1, pnpm 10.22.0)pnpm --filter=dokploy exec biome check <two changed files>(pass)pnpm --filter=dokploy run typecheck(pass)pnpm --filter=dokploy exec vitest --config __test__/vitest.config.ts --exclude __test__/deploy/application.real.test.ts(pass: 80 files, 711 tests)BETTER_AUTH_SECRET=<ephemeral local value> pnpm --filter=dokploy run build(pass; the secret was not persisted or printed)Rollout / rollback
Normal frontend deployment. Roll back by reverting commit
18618e73e; no data or configuration rollback is required.Checklist
canary.CONTRIBUTING.md.Issues related (if applicable)
None.
Screenshots (if applicable)
Not applicable; behavior-only control-state fix.
Summary by CodeRabbit