Skip to content

Feature/increase worker count - #740

Open
MKoesters wants to merge 8 commits into
BiBiServ:masterfrom
MKoesters:feature/increase-worker-count
Open

Feature/increase worker count#740
MKoesters wants to merge 8 commits into
BiBiServ:masterfrom
MKoesters:feature/increase-worker-count

Conversation

@MKoesters

@MKoesters MKoesters commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Adresses #718

This PR allows to increase the number of worker nodes of an already existing cluster.

In order to increate worker count, change the number of workers in the config and reapply the config using the -cid CLI argument of an existing cluster.

Currently, only increasing worker node count is supported, other attributes cant be updated yet.
That would probably require a more sophisticated approach.

@XaverStiensmeier Would love to have some feedback from your side

I did test this by increasing the worker count of a running cluster.
I ended up with an additional, functional node in the same partition.

@XaverStiensmeier

XaverStiensmeier commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Looks great!

I am on holidays starting tomorrow and will not have the time to review it before, but while it takes a different approach then I had in mind, I feel like it is also a valid implementation; without using the existing update route. I will take a closer look once I am back.

@XaverStiensmeier

Copy link
Copy Markdown
Contributor

I am still convinced that such a future change of the worker count should not be part of the regular create command, but of the update command: bibigrid/core/actions/update.py

This also avoids overloading the create command which might confuse users. What do you think?

@MKoesters

Copy link
Copy Markdown
Contributor Author

I agree. I already implemted that change and thought that ive already pushed that here.
Apparently I did not.
Ill do this in the beginningoft next week and ping you

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants