Feature/increase worker count - #740
Open
MKoesters wants to merge 8 commits into
Open
Conversation
MAX_ID_LENGTH suggests a maximum length, not a static length. I adapted the condition accordingly
Contributor
|
Looks great! I am on holidays starting tomorrow and will not have the time to review it before, but while it takes a different approach then I had in mind, I feel like it is also a valid implementation; without using the existing update route. I will take a closer look once I am back. |
Contributor
|
I am still convinced that such a future change of the worker count should not be part of the regular create command, but of the update command: bibigrid/core/actions/update.py This also avoids overloading the create command which might confuse users. What do you think? |
Contributor
Author
|
I agree. I already implemted that change and thought that ive already pushed that here. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #718
This PR allows to increase the number of worker nodes of an already existing cluster.
In order to increate worker count, change the number of workers in the config and reapply the config using the
-cidCLI argument of an existing cluster.Currently, only increasing worker node count is supported, other attributes cant be updated yet.
That would probably require a more sophisticated approach.
@XaverStiensmeier Would love to have some feedback from your side
I did test this by increasing the worker count of a running cluster.
I ended up with an additional, functional node in the same partition.