Skip to content

Fix incorrect type hints for poppler_path arguments #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartfeenstra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect type hints for poppler_path arguments #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions pdf2image/pdf2image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import shutil
import subprocess
from subprocess import Popen, PIPE, TimeoutExpired
from typing import Any, Union, Tuple, List, Dict, Callable
from typing import Any, Union, Tuple, List, Dict, Callable, Optional
from pathlib import PurePath
from PIL import Image

Expand Down Expand Up @@ -50,7 +50,7 @@ def convert_from_path(
transparent: bool = False,
single_file: bool = False,
output_file: Any = uuid_generator(),
poppler_path: Union[str, PurePath] = None,
poppler_path: Optional[Union[str, PurePath]] = None,
grayscale: bool = False,
size: Union[Tuple, int] = None,
paths_only: bool = False,
Expand Down Expand Up @@ -91,7 +91,7 @@ def convert_from_path(
:param output_file: What is the output filename or generator, defaults to uuid_generator()
:type output_file: Any, optional
:param poppler_path: Path to look for poppler binaries, defaults to None
:type poppler_path: Union[str, PurePath], optional
:type poppler_path: Optional[Union[str, PurePath]]
:param grayscale: Output grayscale image(s), defaults to False
:type grayscale: bool, optional
:param size: Size of the resulting image(s), uses the Pillow (width, height) standard, defaults to None
Expand Down Expand Up @@ -290,7 +290,7 @@ def convert_from_bytes(
transparent: bool = False,
single_file: bool = False,
output_file: Union[str, PurePath] = uuid_generator(),
poppler_path: Union[str, PurePath] = None,
poppler_path: Optional[Union[str, PurePath]] = None,
grayscale: bool = False,
size: Union[Tuple, int] = None,
paths_only: bool = False,
Expand Down Expand Up @@ -331,7 +331,7 @@ def convert_from_bytes(
:param output_file: What is the output filename or generator, defaults to uuid_generator()
:type output_file: Any, optional
:param poppler_path: Path to look for poppler binaries, defaults to None
:type poppler_path: Union[str, PurePath], optional
:type poppler_path: Optional[Union[str, PurePath]]
:param grayscale: Output grayscale image(s), defaults to False
:type grayscale: bool, optional
:param size: Size of the resulting image(s), uses the Pillow (width, height) standard, defaults to None
Expand Down Expand Up @@ -486,7 +486,7 @@ def _parse_jpegopt(jpegopt: Dict) -> str:
return ",".join(parts)


def _get_command_path(command: str, poppler_path: str = None) -> str:
def _get_command_path(command: str, poppler_path: Optional[Union[str, PurePath]] = None) -> str:
if platform.system() == "Windows":
command = command + ".exe"

Expand All @@ -497,7 +497,7 @@ def _get_command_path(command: str, poppler_path: str = None) -> str:


def _get_poppler_version(
command: str, poppler_path: str = None, timeout: int = None
command: str, poppler_path: Optional[Union[str, PurePath]] = None, timeout: int = None
) -> Tuple[int, int]:
command = [_get_command_path(command, poppler_path), "-v"]

Expand Down Expand Up @@ -526,7 +526,7 @@ def pdfinfo_from_path(
pdf_path: str,
userpw: str = None,
ownerpw: str = None,
poppler_path: str = None,
poppler_path: Optional[Union[str, PurePath]] = None,
rawdates: bool = False,
timeout: int = None,
first_page: int = None,
Expand All @@ -541,7 +541,7 @@ def pdfinfo_from_path(
:param ownerpw: PDF's owner password, defaults to None
:type ownerpw: str, optional
:param poppler_path: Path to look for poppler binaries, defaults to None
:type poppler_path: Union[str, PurePath], optional
:type poppler_path: Optional[Union[str, PurePath]]
:param rawdates: Return the undecoded data strings, defaults to False
:type rawdates: bool, optional
:param timeout: Raise PDFPopplerTimeoutError after the given time, defaults to None
Expand Down Expand Up @@ -617,7 +617,7 @@ def pdfinfo_from_bytes(
pdf_bytes: bytes,
userpw: str = None,
ownerpw: str = None,
poppler_path: str = None,
poppler_path: Optional[Union[str, PurePath]] = None,
rawdates: bool = False,
timeout: int = None,
first_page: int = None,
Expand All @@ -632,7 +632,7 @@ def pdfinfo_from_bytes(
:param ownerpw: PDF's owner password, defaults to None
:type ownerpw: str, optional
:param poppler_path: Path to look for poppler binaries, defaults to None
:type poppler_path: Union[str, PurePath], optional
:type poppler_path: Optional[Union[str, PurePath]]
:param rawdates: Return the undecoded data strings, defaults to False
:type rawdates: bool, optional
:param timeout: Raise PDFPopplerTimeoutError after the given time, defaults to None
Expand Down