Any interest in new feature: Getting URLs from pdfinfo?#257
Draft
jpreiss wants to merge 1 commit into
Draft
Conversation
fix type annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using your library to rasterize PDFs in my presentation viewer https://github.com/jpreiss/pypdfdeck (branch
videos).I want to add a feature where any embedded URL that starts with
file://is interpreted to mean "instead of the PDF contents, display the video from this local path when viewing this page".The command line
pdfinfocan extract the URLs, but it is not exposed through the current python interface.To do this, it would be nice if I can lean on
pdf2imageto properly find the poppler binaries, etc. Therefore, I added the option to extract URLs inpdfinfo_from_path().This is not ready to merge - it needs design review, tests, equivalent
_from_bytes()version, better docs, etc. Just wanted to check if this feature is actually desired before I finish the work.Thanks!