feat: self-hosted backend URL override in Developer Settings #6604
+171
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,14 +40,23 @@ class DeveloperSettingsPage extends StatefulWidget { | |
| } | ||
|
|
||
| class _DeveloperSettingsPageState extends State<DeveloperSettingsPage> { | ||
| final _backendUrlController = TextEditingController(); | ||
|
|
||
| @override | ||
| void initState() { | ||
| _backendUrlController.text = SharedPreferencesUtil().customBackendUrl; | ||
| WidgetsBinding.instance.addPostFrameCallback((_) async { | ||
| context.read<McpProvider>().fetchKeys(); | ||
| }); | ||
| super.initState(); | ||
| } | ||
|
|
||
| @override | ||
| void dispose() { | ||
| _backendUrlController.dispose(); | ||
| super.dispose(); | ||
| } | ||
|
|
||
| Widget _buildSectionContainer({required List<Widget> children}) { | ||
| return Container( | ||
| decoration: BoxDecoration(color: const Color(0xFF1C1C1E), borderRadius: BorderRadius.circular(12)), | ||
|
|
@@ -603,6 +612,118 @@ class _DeveloperSettingsPageState extends State<DeveloperSettingsPage> { | |
| ), | ||
| const SizedBox(height: 32), | ||
|
|
||
| // Self-Hosted Backend Section | ||
| _buildSectionHeader( | ||
| context.l10n.selfHostedBackendSectionTitle, | ||
| subtitle: context.l10n.selfHostedBackendSubtitle, | ||
| ), | ||
| Container( | ||
| padding: const EdgeInsets.all(16), | ||
| decoration: BoxDecoration(color: const Color(0xFF1C1C1E), borderRadius: BorderRadius.circular(14)), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Row( | ||
| children: [ | ||
| Container( | ||
| width: 40, | ||
| height: 40, | ||
| decoration: BoxDecoration( | ||
| color: const Color(0xFF2A2A2E), | ||
| borderRadius: BorderRadius.circular(10), | ||
| ), | ||
| child: Center( | ||
| child: FaIcon(FontAwesomeIcons.server, color: Colors.grey.shade400, size: 16), | ||
| ), | ||
| ), | ||
| const SizedBox(width: 14), | ||
| Expanded( | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| Text( | ||
| context.l10n.backendUrlLabel, | ||
| style: const TextStyle(color: Colors.white, fontSize: 16, fontWeight: FontWeight.w500), | ||
| ), | ||
| const SizedBox(height: 2), | ||
| Text( | ||
| Env.apiBaseUrl ?? 'https://api.omi.me', | ||
| style: TextStyle(color: Colors.grey.shade500, fontSize: 12), | ||
| overflow: TextOverflow.ellipsis, | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| const SizedBox(height: 16), | ||
| TextField( | ||
| controller: _backendUrlController, | ||
| style: const TextStyle(color: Colors.white, fontSize: 14), | ||
| decoration: InputDecoration( | ||
| hintText: context.l10n.selfHostedBackendUrlHint, | ||
| hintStyle: TextStyle(color: Colors.grey.shade600, fontSize: 14), | ||
| filled: true, | ||
| fillColor: const Color(0xFF2A2A2E), | ||
| border: OutlineInputBorder( | ||
| borderRadius: BorderRadius.circular(10), | ||
| borderSide: BorderSide.none, | ||
| ), | ||
| contentPadding: const EdgeInsets.symmetric(horizontal: 14, vertical: 12), | ||
| suffixIcon: _backendUrlController.text.isNotEmpty | ||
| ? IconButton( | ||
| icon: Icon(Icons.clear, color: Colors.grey.shade500, size: 18), | ||
| onPressed: () { | ||
| _backendUrlController.clear(); | ||
| SharedPreferencesUtil().customBackendUrl = ''; | ||
| setState(() {}); | ||
| AppSnackbar.showSnackbar(context.l10n.selfHostedBackendClearedRestart); | ||
| }, | ||
| ) | ||
| : null, | ||
| ), | ||
| onChanged: (_) => setState(() {}), | ||
| keyboardType: TextInputType.url, | ||
| autocorrect: false, | ||
| ), | ||
| const SizedBox(height: 12), | ||
| SizedBox( | ||
| width: double.infinity, | ||
| child: ElevatedButton( | ||
| onPressed: () { | ||
| final url = _backendUrlController.text.trim().replaceAll(RegExp(r'/+$'), ''); | ||
| if (url.isNotEmpty && !url.startsWith('http')) { | ||
| AppSnackbar.showSnackbar(context.l10n.selfHostedBackendHttpError); | ||
| return; | ||
| } | ||
| SharedPreferencesUtil().customBackendUrl = url; | ||
| setState(() {}); | ||
| AppSnackbar.showSnackbar( | ||
| url.isEmpty | ||
| ? context.l10n.selfHostedBackendRestoredRestart | ||
| : context.l10n.selfHostedBackendSavedRestart, | ||
| ); | ||
| }, | ||
| style: ElevatedButton.styleFrom( | ||
| backgroundColor: const Color(0xFF2A2A2E), | ||
| foregroundColor: Colors.white, | ||
| padding: const EdgeInsets.symmetric(vertical: 12), | ||
| shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(10)), | ||
| elevation: 0, | ||
| ), | ||
| child: Text(context.l10n.selfHostedBackendSaveButton, style: const TextStyle(fontWeight: FontWeight.w500)), | ||
| ), | ||
| ), | ||
| const SizedBox(height: 10), | ||
| Text( | ||
| context.l10n.selfHostedBackendNote, | ||
| style: TextStyle(color: Colors.grey.shade600, fontSize: 11), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
|
Comment on lines
+615
to
+724
Contributor
There was a problem hiding this comment.
All user-visible strings in this section are hardcoded English. The codebase rule requires
Add the corresponding keys to Context Used: Flutter localization - all user-facing strings mus... (source) |
||
| const SizedBox(height: 32), | ||
|
|
||
| // Debug Logs Section | ||
| _buildSectionHeader(context.l10n.debugAndDiagnostics), | ||
| Container( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Env.overrideApiBaseUrl('')sets_apiBaseUrlOverride = ''. BecauseEnv.apiBaseUrluses_apiBaseUrlOverride ?? _instance.apiBaseUrl, an empty string is non-null and passes the??check, so all API calls from this point forward will construct requests against''and fail immediately — before the required restart.The snackbar already communicates that a restart is needed, so the live
Env.overrideApiBaseUrlcall on clear is not just redundant but actively harmful. Remove it: