Skip to content

Fix encoding ResourceRecord with underscore on their name #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelwilliams merged 1 commit into from
Jul 9, 2026
Merged

Fix encoding ResourceRecord with underscore on their name #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ResourceRecord.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public function toWire(): string
throw new UnsetValueException('ResourceRecord TTL has not been set.');
}

if (!Validator::fullyQualifiedDomainName($this->name)) {
if (!Validator::fullyQualifiedDomainName($this->name, false)) {
throw new InvalidArgumentException(sprintf('"%s" is not a fully qualified domain name.', $this->name));
}

Expand Down
13 changes: 13 additions & 0 deletions tests/ResourceRecordTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,19 @@ public function testToWire(): void
$this->assertEquals($expectation, $rr->toWire());
}

public function testToWireNameWithUnderscore(): void
{
$rr = new ResourceRecord();
$rr->setName('_sip._tcp.example.com.');
$rr->setClass(Classes::INTERNET);
$rr->setRdata(Factory::SRV(0, 5, 5060, 'sip.example.com.'));
$rr->setTtl(3600);

$decoded = ResourceRecord::fromWire($rr->toWire());

$this->assertEquals('_sip._tcp.example.com.', $decoded->getName());
}

public function dataProviderForTestToWireThrowsExceptionsIfValuesAreNotSet(): array
{
$rr_noName = new ResourceRecord();
Expand Down
Loading