Skip to content

Modernize fragment menus, XML converter, and custom header UI - #3

Merged
MinecraftFuns merged 4 commits into
masterfrom
copilot/update-syntax-and-fix-ux-issues
Dec 17, 2025
Merged

MinecraftFuns merged 4 commits into
masterfrom
copilot/update-syntax-and-fix-ux-issues

Conversation

Copilot AI commented Dec 16, 2025 •

Copy link
Copy Markdown
  • Fix lint unused resource errors for header/custom header strings
  • Re-run lint command from CI
  • Re-run unit tests (testDebugUnitTest)
  • Re-run build (assembleDebug)
  • Address code review and security scan feedback
Original prompt

can you resolve the following warnings in the codebase by updating them to the latest non-deprecated syntax/library function (following best practices; ensure the new code is functional and don't break things), and another CI failure regarding dependency verification? can you also fix a UI/UX issue with the newly added custom http headers authentication where if you select Cloudflare, and then select Custom, the UI/UX has some glitches and the items overlap on screen? think carefully and reason about why this would happen and ensure it doesn't happen again.

Task :app:compileDebugKotlin
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/AboutFragment.kt:40:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/AboutFragment.kt:101:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/AccountFragment.kt:186:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/AccountFragment.kt:189:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/AccountFragment.kt:198:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/CustomHeadersFragment.kt:64:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/CustomHeadersFragment.kt:67:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/CustomHeadersFragment.kt:74:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/LicensesFragment.kt:12:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/fragments/LicensesFragment.kt:15:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@deprecated' annotation or suppress the diagnostic.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/provider/WebDavClient.kt:29:8 'class SimpleXmlConverterFactory : Converter.Factory' is deprecated. Deprecated in Java.
w: file:///home/runner/work/webdav-provider/webdav-provider/app/src/main/java/dev/rocli/android/webdav/provider/WebDavClient.kt:259:25 'class SimpleXmlConverterFactory : Converter.Factory' is deprecated. Deprecated in Java.

Task :app:compileDebugJavaWithJavac
Task :app:hiltAggregateDepsDebug
Task :app:hiltJavaCompileDebug
Task :app:bundleDebugClassesToCompileJar
Task :app:generateDebugLintReportModel
Task :app:generateDebugAndroidTestLintModel
Task :app:generateDebugUnitTestLintModel FAILED

FAILURE: Build failed with an exception.
31 actionable tasks: 31 executed

  • What went wrong:
    Execution failed for task ':app:generateDebugUnitTestLintModel'.

Dependency verification failed for configuration ':app:debugUnitTestCompileClasspath'
2 artifacts failed verification:
- mockwebserver-4.12.0.jar (com.squareup.okhttp3:mockwebserver:4.12.0) from repository MavenRepo
- mockwebserver-4.12.0.module (com.squareup.okhttp3:mockwebserver:4.12.0) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file. For more on how to do this, please refer to https://docs.gradle.org/8.9/userguide/dependency_verification.html#sec:troubleshooting-verification in the Gradle documentation.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Dec 16, 2025
Copilot AI and others added 2 commits December 17, 2025 00:00
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Copilot AI changed the title [WIP] Update deprecated syntax and resolve CI dependency verification Modernize fragment menus, XML converter, and custom header UI Dec 17, 2025
Copilot AI requested a review from MinecraftFuns December 17, 2025 00:12
@MinecraftFuns

Copy link
Copy Markdown

@copilot the linting is failing. please fix this specific problem, re-run linting to identify if there are more problems, and re-run all commands that are tested in the CI to ensure no CI fails.

Task :app:lintDebug FAILED
Lint found 6 errors, 34 warnings. First failure:

/home/runner/work/WebDAV/WebDAV/app/src/main/res/values/strings.xml:88: Error: The resource R.string.header_profile_none appears to be unused [UnusedResources]
None
~~~~~~~~~~~~~~~~~~~~~~~~~~

The full lint text report is located at:
/home/runner/work/WebDAV/WebDAV/app/build/intermediates/lint_intermediate_text_report/debug/lintReportDebug/lint-results-debug.txt
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/session/KaSessionProvider#getAnalysisSession(Lorg/jetbrains/kotlin/psi/KtElement;Lorg/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeTokenFactory;)Lorg/jetbrains/kotlin/analysis/api/KaSession;
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/session/KaSessionProvider#getNoWriteActionInAnalyseCallChecker()Lorg/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker;
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker#beforeEnteringAnalysisContext()V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeTokenFactory#beforeEnteringAnalysisContext(Lorg/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeToken;)V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeTokenFactory#afterLeavingAnalysisContext(Lorg/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeToken;)V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/session/KaSessionProvider#getNoWriteActionInAnalyseCallChecker()Lorg/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker;
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker#afterLeavingAnalysisContext()V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeTokenFactory#afterLeavingAnalysisContext(Lorg/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeToken;)V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/session/KaSessionProvider#getNoWriteActionInAnalyseCallChecker()Lorg/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker;
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker#afterLeavingAnalysisContext()V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeTokenFactory#afterLeavingAnalysisContext(Lorg/jetbrains/kotlin/analysis/api/lifetime/KaLifetimeToken;)V
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/session/KaSessionProvider#getNoWriteActionInAnalyseCallChecker()Lorg/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker;
WARNING: Missing analysis API method org/jetbrains/kotlin/analysis/api/lifetime/impl/NoWriteActionInAnalyseCallChecker#afterLeavingAnalysisContext()V

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':app:lintDebug'.

Lint found errors in the project; aborting build.

Fix the issues identified by lint, or create a baseline to see only new errors.
36 actionable tasks: 36 executed
To create a baseline, run gradlew updateLintBaseline after adding the following to the module's build.gradle file:

android {
    lint {
        baseline = file("lint-baseline.xml")
    }
}

For more details, see https://developer.android.com/studio/write/lint#snapshot

Lint found 6 errors, 34 warnings. First failure:

/home/runner/work/WebDAV/WebDAV/app/src/main/res/values/strings.xml:88: Error: The resource R.string.header_profile_none appears to be unused [UnusedResources]
None
~~~~~~~~~~~~~~~~~~~~~~~~~~

The full lint text report is located at:
/home/runner/work/WebDAV/WebDAV/app/build/intermediates/lint_intermediate_text_report/debug/lintReportDebug/lint-results-debug.txt

  • Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
Get more help at https://help.gradle.org./

BUILD FAILED in 1m 54s
Error: Process completed with exit code 1.

Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>

Copilot AI commented Dec 17, 2025

Copy link
Copy Markdown
Author

@copilot the linting is failing. please fix this specific problem, re-run linting to identify if there are more problems, and re-run all commands that are tested in the CI to ensure no CI fails.

...

Fixed unused header strings and reran CI-equivalent commands; lint, testDebugUnitTest, and assembleDebug all pass now. Commit: 4cf20e3.

@MinecraftFuns
MinecraftFuns marked this pull request as ready for review December 17, 2025 02:17
@MinecraftFuns
MinecraftFuns merged commit 9b1aeb1 into master Dec 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants