Move pointer types into the code model - #5430
Merged
Merged
Conversation
Added Ptr<T> to the code model allowing pointer-to-type to be explicitly modeled. This replaces "byValue" fields on various code model types. This also codifies the rules about what's actually emitted as pointer-to-type, e.g. maps/slices are never pointer-to-type which is now accurately reflected in the code model. In addition, emitting a "*" or "&" prefix on a type is now centralized instead of being spread all over with a few duplicate implementations.
microsoft-github-policy-service
Bot
added
the
emitter:go
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
📦 Package size report1 package changed size, +2.43 KB (+0.0%) packed overall.
12 package(s) with no notable change
Packed = gzipped |
Contributor
Go emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-go-html artifact. Informational check (core/eng/emitter-diff); does not block the PR. |
commit: |
Contributor
|
You can try these changes here
|
Heath Stewart (heaths)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Ptr to the code model allowing pointer-to-type to be explicitly modeled. This replaces "byValue" fields on various code model types. This also codifies the rules about what's actually emitted as pointer-to-type, e.g. maps/slices are never pointer-to-type which is now accurately reflected in the code model.
In addition, emitting a "*" or "&" prefix on a type is now centralized instead of being spread all over with a few duplicate implementations.
No functional changes.