Repository navigation
Make core-commit.json pin authoritative in CoreCommit.ps1 - #5016
Merged
Weidong Xu (weidongxu-microsoft) merged 2 commits intoJul 22, 2026
Merged
Weidong Xu (weidongxu-microsoft) merged 2 commits into
Weidong Xu (weidongxu-microsoft) merged 2 commits into
Conversation
Remove the + 'merge-base --is-ancestor' + gate that only advanced to the pinned core commit when it was a descendant of the submodule checkout. A shallow submodule clone (as on CI) lacks the connecting history and cannot prove ancestry, so the gate silently fell back to the submodule checkout and built the Java emitter from the wrong core sources (e.g. pre-XML-fix code referencing a non-generated XmlSerializerProviders). The pin in core-commit.json is now authoritative: always build from exactly that commit via git archive, harden the fetch with a post-fetch existence check, and update the header doc accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7
microsoft-github-policy-service
Bot
added
the
emitter:java
Xiaofei Cao (XiaofeiCao)
approved these changes
Jul 22, 2026
Contributor
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
The following packages have already been documented:
Show changes
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7
Contributor
|
You can try these changes here
|
commit: |
Weidong Xu (weidongxu-microsoft)
merged commit Jul 22, 2026
0606213
into
release/july-2026
29 checks passed
Weidong Xu (weidongxu-microsoft)
deleted the
fix/typespec-java-core-commit-pin-july-2026
branch
July 22, 2026 08:40
Weidong Xu (weidongxu-microsoft)
added a commit
that referenced
this pull request
Jul 24, 2026
Version bump for the typespec-java hotfix **0.45.10**, following the sync in #5043. ## Included changes (consumed from + '.chronus/changes' + ) - **fix**: Expose the + ' equired-fields-as-ctor-args' + emitter option in + ' spconfig.yaml' + (microsoft/typespec#11380). Default remains + ' rue' + . - **internal**: Make the + 'core-commit.json' + pin authoritative in + 'CoreCommit.ps1' + (#5016). ## Files - + 'packages/typespec-java/package.json' + -> 0.45.10 - + 'packages/typespec-java/CHANGELOG.md' + - + 'packages/typespec-java/emitter-tests/package.json' + -> 0.45.10 (version + + '.tgz' + dep) - Deleted the two consumed typespec-java change files Only + '@azure-tools/typespec-java' + is bumped. Non-java pending change files (tcgc, benchmark, playground, website) were intentionally left untouched. The + 'core' + submodule is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the fix validated on the backmerge PR #5014.
Problem
Fix
Verified locally: with the submodule at + ' eafcd0e' + and pin + '43ff0041' + (the exact CI failure scenario), it now archives + '43ff0041' + with the generator subtree present.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Copilot-Session: cd6f2e08-d6d3-42ae-affd-bc71e98086f7