Skip to content

added graph query to D01.03 DDOS Protection '143b16c3-1d7a-4a9b-9470-4489a8042d88' #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jodyford-msft wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

added graph query to D01.03 DDOS Protection '143b16c3-1d7a-4a9b-9470-4489a8042d88' #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d75db8
added graph query to D01.03 DDOS Protection
Sep 24, 2024
5bb5bad
corrected query for ip addresses
Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions checklists/alz_checklist.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@
"guid": "143b16c3-1d7a-4a9b-9470-4489a8042d88",
"id": "D01.03",
"severity": "High",
"graph": "resources | where type =~ 'microsoft.network/publicIPAddresses' | extend properties = parse_json(properties) | project id, name, location, ddosProtectionPlan = properties.ddosSettings.protectionPlan | extend compliant = iff(isnotempty(ddosProtectionPlan), 1, 0) | where compliant == 1 project id, compliant",
Copy link
Copy Markdown
Collaborator

@erjosito erjosito Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I believe that there is a | missing after compliant == 1 right?
  • But more importantly, could you please remove the where compliant == 1 altogether? Otherwise the non-compliant resources don't show up.

"training": "https://learn.microsoft.com/learn/paths/secure-networking-infrastructure/",
"link": "https://learn.microsoft.com/azure/ddos-protection/ddos-protection-overview"
},
Expand Down
1 change: 1 addition & 0 deletions checklists/waf_checklist.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4674,6 +4674,7 @@
"link": "https://learn.microsoft.com/azure/ddos-protection/ddos-protection-overview",
"service": "VNet",
"severity": "High",
"graph": "resources | where type =~ 'microsoft.network/publicIPAddresses' | extend properties = parse_json(properties) | project id, name, location, ddosProtectionPlan = properties.ddosSettings.protectionPlan | extend compliant = iff(isnotempty(ddosProtectionPlan), 1, 0) | where compliant == 1 project id, compliant",
Copy link
Copy Markdown
Collaborator

@erjosito erjosito Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I believe that there is a | missing after compliant == 1 right?
  • But more importantly, could you please remove the where compliant == 1 altogether? Otherwise the non-compliant resources don't show up.

"text": "Use a DDoS Network or IP protection plan for all public IP addresses in application landing zones.",
"training": "https://learn.microsoft.com/learn/paths/secure-networking-infrastructure/",
"waf": "Security"
Expand Down