Repository navigation
Require language selection in arch board review template - #10184
Merged
Praveen Kuttappan (praveenkuttappan) merged 1 commit intoJul 27, 2026
Merged
Praveen Kuttappan (praveenkuttappan) merged 1 commit into
Praveen Kuttappan (praveenkuttappan) merged 1 commit into
Conversation
Convert the "Languages for this Review" field from an optional checkbox group to a required multi-select dropdown so submissions can never omit a language. GitHub issue forms cannot require "at least one" checkbox, but a multi-select dropdown with validations.required enforces a non-empty selection at submit time, closing the empty-languages gap that produced "No languages were selected" bounces during triage. Make getSelectedLanguages tolerant of both renderings: the dropdown's comma-separated value list and the legacy checkbox format, keeping existing open issues and triage parsing working. Add a parser test for the dropdown rendering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f922dad1-6173-4c65-b4bb-03f056572963
Sameeksha Vaity (samvaity)
requested review from
a team,
Jesse Squire (jsquire),
Laurent Mazuel (lmazuel),
Mayuri Diwan (mayurid) and
Jeff Fisher (xirzec)
as code owners
July 27, 2026 20:58
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Jeff Fisher (xirzec)
approved these changes
Jul 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Requires at least one language for Architecture Board reviews while preserving legacy issue parsing.
Changes:
- Replaces language checkboxes with a required multi-select dropdown.
- Supports dropdown and legacy checkbox renderings.
- Adds dropdown parsing coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/ISSUE_TEMPLATE/arch-board-review.yml |
Makes language selection required. |
.github/workflows/src/arch-board-review/issue-parsing.js |
Parses both language-selection formats. |
.github/workflows/test/arch-board-review/issue-parsing.test.js |
Tests multi-select parsing. |
Praveen Kuttappan (praveenkuttappan)
merged commit Jul 27, 2026
d70c03b
into
Azure:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the Languages for this Review field in the Architecture Board API-review issue template required, so a submission can never be filed with zero languages selected.
checkboxesgroup to a multi-selectdropdown(multiple: true) withvalidations.required: true.requiredflag on checkboxes is per individual option), so a required multi-select dropdown is the only control that enforces a non-empty selection at submit time.Why
Empty language selections currently slip through and get bounced during triage with a "No languages were selected" comment (an avoidable round trip). Enforcing selection upfront means issues reliably reach
ready-for-review, which keeps per-language board views and architect assignment (#10167) accurate.Parser compatibility
getSelectedLanguagesis now tolerant of both renderings:Java, Python), and- [x] Javacheckbox format,so existing open issues and all triage/assignment parsing keep working. Added a parser test for the dropdown rendering. Full suite green, eslint + prettier clean.
Note
This is a focused follow-up to #10167 (architect assignment) and does not touch that PR's assignment logic. Assignment stays at
ready-for-review; this change just makes reaching that state more reliable.