Repository navigation
AutoPR regeneration should identify retrigger source #16790
Description
Context
For Azure/azure-sdk-for-python#48594, the Python SDK PR had already been approved.
However, the release plan retriggered SDK generation, and the previous approval no longer worked. This requires reviewers to spend time reviewing the generated PR again, which is not a good experience.
Problem
- Approval can become invalid after the release plan retriggers SDK generation.
- Reviewers cannot tell who or what retriggered the generation, or why it happened.
- This creates unnecessary repeated review work for generated SDK PRs.
Expected behavior
At minimum, reviewers should be able to see who/what retriggered SDK generation and why. So I would like a comment in PR with the context.
Activity
[-]AutoPR regeneration should preserve approval context or identify retrigger source[/-][+]AutoPR regeneration should identify retrigger source[/+]lirenhe commentedon Aug 21, 2026
Some spec PR updates after SDK PR has been submitted should be fine, but I hope the release plan could do:
raych1 commentedon Aug 21, 2026
Praveen Kuttappan (@praveenkuttappan) , can you check if release plan can introduce another state like
Re-review-requested? Or, we could leverage GH branch policy to dismiss the approval status when new commit pushes.Renhe Li (@lirenhe) Yuchao Yan (@msyyc)
The PR description in the first comment is updated with new commit information. Reviewers can browse to the commit to understand details.
praveenkuttappan commentedon Sep 1, 2026
Ray Chen (@raych1) I don't know if we need to add logic in release planner or use GH policy. But GH policy might be challenging if data plane does not want to invalidate approval status when a new commit is added. Release plan does not record PR status and this is fetched dynamically from GitHub. So it will be a big change to keep the status and sync it with GH status in release plan. Release plan dashboard is completely a read only app.
lirenhe commentedon Sep 28, 2026
I could not see the image you attached. To clarify, I hope people could filter the release plan to know what are the SDK PRs that they need to review again instead of opening each PRs and reading the description to understand this. thanks
praveenkuttappan commentedon Oct 5, 2026
Helen Gao (@helen229) Can you please make a change in release plan dashboard to show even approved PRs but that has a new merge?
Release plan dashboard should show all review required PR and any approved PR that has a new commit since last approval.
helen229 commentedon Oct 7, 2026
Closing this issue in favor of #17206 — Load SDK PR review badges with PR status. The implementation is in dashboard PR #62.
The new issue also fixes the UI bug where review badges appeared only after expanding a PR. The change loads current-head review status on initial load for all SDK languages and uses the same logic for badges, expanded details, and the reviewer queue.
Open feedback wins over approval. New commits need a new approval. Approved PRs stay in plan details, but still need passing checks before merge.
Dashboard PR #62 still needs merge and deployment. #17206 tracks the remaining work.
praveenkuttappan commentedon Oct 13, 2026
Completed. Dashboard now shows only reviewed required pr list and not the approved PRs.