Skip to content

Limit the number of confidential ledger tests run on the nightly schedule to one - #48598

Merged
msftsettiy merged 12 commits into
Azure:mainfrom
msftsettiy:reduce-ledger-test-frequency
Aug 21, 2026
Merged

msftsettiy merged 12 commits into
Azure:mainfrom
msftsettiy:reduce-ledger-test-frequency

Conversation

@msftsettiy

Copy link
Copy Markdown
Member

The nightly runs create several confidential ledger resources which are expensive to create. Due to it, the tests fail most of the time as it takes approximately 8 minutes to provision a ledger resource. This PR limits the number of tests being run to a single OS + Python version combination.

The entire matrix is still run on the weekly schedule.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI balanced review requested due to automatic review settings August 14, 2026 22:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Limits costly Confidential Ledger nightly tests while preserving the full weekly matrix.

Changes:

  • Adds schedule-aware matrix filtering.
  • Targets the Python 3.10 coverage leg for non-weekly runs.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/confidentialledger/tests.yml Outdated
Copilot AI review requested due to automatic review settings August 14, 2026 22:51
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

This comment has been minimized.

Copilot AI review requested due to automatic review settings August 17, 2026 21:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

This comment has been minimized.

Copilot AI review requested due to automatic review settings August 17, 2026 22:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

This comment has been minimized.

Copilot AI review requested due to automatic review settings August 18, 2026 13:27
@msftsettiy
msftsettiy enabled auto-merge (squash) August 18, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

A CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green.

What failed

The python - pullrequest pipeline (build 6714589) failed in the Build Analyze job (direct link) due to a pylint validation failure in sdk/confidentialledger/azure-confidentialledger-certificate. Three C0123 (unidiomatic-typecheck) violations were found in azure/confidentialledger/certificate/_utils/model_base.py — pylint requires isinstance() instead of type() for type checks. The sibling package azure-confidentialledger passed pylint with a perfect score.

Recommended next steps

  • In sdk/confidentialledger/azure-confidentialledger-certificate/azure/confidentialledger/certificate/_utils/model_base.py, replace the three type(x) is Y / type(x) == Y checks at lines 820, 823, and 829 with the equivalent isinstance(x, Y) calls to satisfy the C0123 rule.
  • Run azpysdk pylint . from sdk/confidentialledger/azure-confidentialledger-certificate/ locally to confirm the fix before pushing.
  • See the CI troubleshooting guide: https://aka.ms/ci-fix
  • Push new commits to address the failures; this comment updates automatically on the next failing run.
Raw pipeline analysis (azsdk ci analyze)
Build: 6714589 Project: public
PipelineUrl: https://dev.azure.com/azure-sdk/public/_build/results?buildId=6714589

Failed Tasks
[END   2/2] pylint :: azure-confidentialledger-certificate -> FAIL(16) in 12.83s

azure/confidentialledger/certificate/_utils/model_base.py:820: [C0123(unidiomatic-typecheck)] Use isinstance() rather than type() for a typecheck.
azure/confidentialledger/certificate/_utils/model_base.py:823: [C0123(unidiomatic-typecheck)] Use isinstance() rather than type() for a typecheck.
azure/confidentialledger/certificate/_utils/model_base.py:829: [C0123(unidiomatic-typecheck)] Use isinstance() rather than type() for a typecheck.

Your code has been rated at 9.98/10

azure-confidentialledger-certificate main package exited with linting error 16.
See: https://aka.ms/azsdk/python/pylint-guide

[END   1/2] pylint :: azure-confidentialledger -> OK in 22.71s (10.00/10)

Summary:
  azure-confidentialledger-certificate  pylint  FAIL(16)  12.83s
  azure-confidentialledger              pylint  OK         22.71s

Failures:
  python - pullrequest [FAILURE]
    https://dev.azure.com/azure-sdk/29ec6040-b234-4e31-b139-33dc4287b756/_build/results?buildId=6714589
  python - pullrequest (Build Analyze) [FAILURE]
    https://dev.azure.com/azure-sdk/29ec6040-b234-4e31-b139-33dc4287b756/_build/results?buildId=6714589&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9

Copilot detected the failing pipeline and generated the analysis above. To have it attempt a fix automatically, reply with @copilot please fix the failing pipeline on this PR.

Generated by Pipeline Analysis - Next Steps · 28.5 AIC · ⌖ 8.81 AIC · ⊞ 6.6K · ◷

Copilot AI review requested due to automatic review settings August 18, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 18, 2026 21:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 20, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 21, 2026 02:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@msftsettiy
msftsettiy merged commit b363ab7 into Azure:main Aug 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants