Skip to content

Sync .github/skills directory with azure-sdk-tools for PR 17350 - #40455

Merged
Helen Gao (helen229) merged 3 commits into
mainfrom
sync-.github-skills-fix/eval-mcp-app-runtime-17350
Oct 22, 2026
Merged

Helen Gao (helen229) merged 3 commits into
mainfrom
sync-.github-skills-fix/eval-mcp-app-runtime-17350

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17350 See eng/common workflow

Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:29
@azure-sdk-automation
azure-sdk-automation Bot requested review from a team as code owners October 22, 2026 21:29
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 22, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The evaluation-only changes have no confirmed blocking issues, and the anti-trigger assertion matches the skill’s required language-selection step.

No open issues 🎉

What changed in this PR

Syncs shared skill evaluations from azure-sdk-tools PR #17350 into the JavaScript SDK repository. Changes affect evaluation configuration only, not SDK runtime code.

Changes:

  • Replaces top-level config with defaults in four evaluation files.
  • Adds explicit skill availability and updates skill-invocation assertions.
  • Makes the release-plan scheduling prompt relative to the current date.
File Description
.github/​skills/​azsdk-common-sdk-release/​evals/​eval.yaml Updates defaults and release-skill invocation checks.
.github/​skills/​azsdk-common-sdk-breaking-change/​evals/​trigger.eval.yaml Makes the breaking-change skill explicitly available.
.github/​skills/​azsdk-common-prepare-release-plan/​evals/​schedule-risk.eval.yaml Uses next calendar month and clarifies the mock’s warning role.
.github/​skills/​azsdk-common-prepare-release-plan/​evals/​eval.yaml Moves execution settings to defaults.
.github/​skills/​azsdk-common-generate-sdk-locally/​evals/​trigger.eval.yaml Exposes both skills and requires breaking-change routing for the anti-trigger case.
.github/​skills/​azsdk-common-generate-sdk-locally/​evals/​eval.yaml Moves execution settings to defaults.
.github/​skills/​azsdk-common-apiview-feedback-resolution/​evals/​eval.yaml Moves execution settings to defaults.

Review effort: Balanced

@helen229 Helen Gao (helen229) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the shared-skill eval sync from Azure/azure-sdk-tools#17350. All seven file changes match the source and the referenced breaking-change skill is present in this repository.

@helen229
Helen Gao (helen229) merged commit 9cc9031 into main Oct 22, 2026
23 of 24 checks passed
@helen229
Helen Gao (helen229) deleted the sync-.github-skills-fix/eval-mcp-app-runtime-17350 branch October 22, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants