Skip to content

Sync .github/skills directory with azure-sdk-tools for PR 16972 - #39931

Merged
Helen Gao (helen229) merged 2 commits into
mainfrom
sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972
Sep 11, 2026
Merged

Helen Gao (helen229) merged 2 commits into
mainfrom
sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16972 See eng/common workflow

Surface past-due and due-soon plans for the same TypeSpec project during get and create workflows, and align skill and mock coverage for spec-PR lookups.
Preserve fetch-stage cancellation, complete mock lookup coverage, retain requested spec PR URLs, and fix the plugin documentation link.
Copilot AI balanced review requested due to automatic review settings September 11, 2026 12:01
@azure-sdk-automation
azure-sdk-automation Bot requested review from a team as code owners September 11, 2026 12:01
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Sep 11, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new evaluations conflict with required input collection and do not fully validate the schedule-risk output contract.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Synchronizes release-plan skill guidance with updated MCP tooling and schedule-risk handling.

Changes:

  • Consolidates release-plan lookup and adds target-month updates.
  • Adds schedule-risk guidance and evaluation scenarios.
File summaries
File Description
.github/skills/azsdk-common-prepare-release-plan/SKILL.md Updates release-plan tools and guidance.
.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml Adds schedule-risk evaluations.
Review details

Suppressed comments (2)

.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:53

  • This grader can pass without the Release Plan ID or dashboard link required by the new skill rule; mentioning an abandonment reason is enough to satisfy its final lookahead. Add explicit assertions for both fields in this spec-PR lookup case.
          pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"

.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:83

  • This create-case grader also omits the required Release Plan ID and dashboard-link checks; the current pattern passes when only a reason is mentioned. Assert both fields so every schedule-risk path validates the full contract introduced in SKILL.md.
          pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

@helen229
Helen Gao (helen229) merged commit 3c82d6d into main Sep 11, 2026
139 of 160 checks passed
@helen229
Helen Gao (helen229) deleted the sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972 branch September 11, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants