Repository navigation
Sync .github/skills directory with azure-sdk-tools for PR 16972 - #39931
Merged
Helen Gao (helen229) merged 2 commits intoSep 11, 2026
Conversation
Surface past-due and due-soon plans for the same TypeSpec project during get and create workflows, and align skill and mock coverage for spec-PR lookups.
Preserve fetch-stage cancellation, complete mock lookup coverage, retain requested spec PR URLs, and fix the plugin documentation link.
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new evaluations conflict with required input collection and do not fully validate the schedule-risk output contract.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Synchronizes release-plan skill guidance with updated MCP tooling and schedule-risk handling.
Changes:
- Consolidates release-plan lookup and adds target-month updates.
- Adds schedule-risk guidance and evaluation scenarios.
File summaries
| File | Description |
|---|---|
.github/skills/azsdk-common-prepare-release-plan/SKILL.md |
Updates release-plan tools and guidance. |
.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml |
Adds schedule-risk evaluations. |
Review details
Suppressed comments (2)
.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:53
- This grader can pass without the Release Plan ID or dashboard link required by the new skill rule; mentioning an abandonment reason is enough to satisfy its final lookahead. Add explicit assertions for both fields in this spec-PR lookup case.
pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"
.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:83
- This create-case grader also omits the required Release Plan ID and dashboard-link checks; the current pattern passes when only a reason is mentioned. Assert both fields so every schedule-risk path validates the full contract introduced in
SKILL.md.
pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
Helen Gao (helen229)
approved these changes
Sep 11, 2026
Helen Gao (helen229)
deleted the
sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972
branch
September 11, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16972 See eng/common workflow